fix: import SimpleMapCoord from @antv/l7-maps - #2740
Closed
GeoDaoyu wants to merge 1 commit into
Closed
Conversation
|
Walkthrough此PR重构了 Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| import Point from '@mapbox/point-geometry'; | ||
| import { DOM } from './util/dom'; | ||
|
|
||
| import { SimpleMapCoord } from '@antv/l7-maps'; |
There was a problem hiding this comment.
确保从@antv/l7-maps导入的SimpleMapCoord类与原本实现的功能一致，以避免潜在的功能性问题。
Contributor
Author
|
lzxue：不能在map 组件导入 antv/l7-maps，这样会有循环引用，反之是可以的。 |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[English Template / 英文模板]
🤔 这个变动的性质是？
🔗 相关 Issue
#2734
💡 需求背景和解决方案
之前不知道如何导入子包的类，所以copy了一份代码到l7-map，现在从@antv/l7-maps导入类。
📝 更新日志
☑️ 请求合并前的自查清单