Skip to content

fix: keep form signup toggle label static - #42167

Merged
sebastianiv21 merged 1 commit into
releasefrom
fix/form-signup-toggle-label
Aug 28, 2026
Merged

fix: keep form signup toggle label static#42167
sebastianiv21 merged 1 commit into
releasefrom
fix/form-signup-toggle-label

Conversation

@sebastianiv21

@sebastianiv21 sebastianiv21 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

In Admin Settings → Authentication → Form login, the signup toggle (isSignupDisabled) rendered its label from the current value: "Allow only invited users to signup" when signup is disabled, "Allow all users to signup" when enabled. Because the label restated the current state, toggling the switch appeared to change the option itself — a customer looking for the "invited users" option couldn't find it while it was enabled, and open signup kept adding unintended members (and paid seats) to their org.

This PR makes the label static — "Allow all users to signup" — so it describes what the setting does: switch ON = anyone can sign up, switch OFF = only invited users can sign up. This matches the static-label pattern of the sibling toggles on the same page ("Enable form login", "Enable email verification") and keeps the accessible name of the switch stable across activation.

Behavior of the setting itself is unchanged; this is label-only.

Call sites checked

  • toggleText is only consumed by FieldToggleWithToggleText in app/client/src/pages/AdminSettings/FormGroup/Toggle.tsx; isSignupDisabled was the only setting supplying a value-dependent one.
  • No Cypress spec or locator references either label string (the signup toggle locator is testid-based: [data-testid='isSignupDisabled']).
  • EE imports FormAuth from ce/ with no override, so this CE-only change flows to EE via the hourly sync (verified it applies cleanly).

Tests

  • New unit test app/client/src/ce/pages/AdminSettings/config/authentication.test.tsx: asserts the label is state-independent and pins the exact wording. Verified red against the pre-fix source, green after.
  • Full src/pages/AdminSettings jest scope passes (13 suites, 39 tests).

Fixes https://linear.app/appsmith/issue/APP-15855

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/33033481965
Commit: b7d0192
Cypress dashboard.
Tags: @tag.All
Spec:


Thu, 27 Aug 2026 03:33:10 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Updated the signup setting label to consistently display “Allow all users to signup,” regardless of the toggle state.
  • Tests

    • Added coverage to verify the signup setting label remains consistent when toggled.

The isSignupDisabled toggle in Admin Settings > Authentication > Form login rendered its label from the current value: 'Allow only invited users to signup' when off, 'Allow all users to signup' when on. A label that restates the state reads as the option itself changing (Pylon 2813). Use a static label describing what the toggle does: ON = anyone can sign up, OFF = invited-only, matching the sibling toggles on the page.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Aug 27, 2026

Copy link
Copy Markdown

APP-15855

@sebastianiv21 sebastianiv21 added the ok-to-test Required label for CI label Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4bb0a6bb-93a0-4ca3-8557-5e610f954d2d

📥 Commits

Reviewing files that changed from the base of the PR and between 2d0433b and b7d0192.

📒 Files selected for processing (2)
  • app/client/src/ce/pages/AdminSettings/config/authentication.test.tsx
  • app/client/src/ce/pages/AdminSettings/config/authentication.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The signup setting now displays “Allow all users to signup” for both toggle states. A test verifies the label remains constant.

Changes

Signup label consistency

Layer / File(s) Summary
Update signup label and test
app/client/src/ce/pages/AdminSettings/config/authentication.tsx, app/client/src/ce/pages/AdminSettings/config/authentication.test.tsx
The setting uses a constant signup label. The test confirms that both toggle states return the same text.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to b7d01

This PR only makes the signup setting label static and adds targeted test coverage; the setting behavior is unchanged, so no actionable merge-blocking risk remains.

Suggested reviewers: amelia-c0n

Poem

A toggle flips with quiet grace
The label stays in its place
No invite words appear
One signup message rings clear
Tests guard the phrase sincere

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: keeping the form signup toggle label static.
Description check ✅ Passed The description is complete and relevant. It explains the issue, behavior change, scope, tests, linked issue, automation, and communication decision.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/form-signup-toggle-label

Warning

Your free Security trial is over. An organization admin can activate billing to continue.


Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the Bug Something isn't working label Aug 27, 2026
@sebastianiv21
sebastianiv21 marked this pull request as ready for review August 27, 2026 02:31
@sebastianiv21
sebastianiv21 requested a review from a team as a code owner August 27, 2026 02:31
@sebastianiv21

Copy link
Copy Markdown
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions

Copy link
Copy Markdown

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/33033598416.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 42167.
recreate: .
base-image-tag: .

@github-actions

Copy link
Copy Markdown

Deploy-Preview-URL: https://ce-42167.dp.appsmith.com

@sebastianiv21
sebastianiv21 merged commit 75847cf into release Aug 28, 2026
89 checks passed
@sebastianiv21
sebastianiv21 deleted the fix/form-signup-toggle-label branch August 28, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working ok-to-test Required label for CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants