fix: keep form signup toggle label static - #42167
Conversation
The isSignupDisabled toggle in Admin Settings > Authentication > Form login rendered its label from the current value: 'Allow only invited users to signup' when off, 'Allow all users to signup' when on. A label that restates the state reads as the option itself changing (Pylon 2813). Use a static label describing what the toggle does: ON = anyone can sign up, OFF = invited-only, matching the sibling toggles on the page. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe signup setting now displays “Allow all users to signup” for both toggle states. A test verifies the label remains constant. ChangesSignup label consistency
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR only makes the signup setting label static and adds targeted test coverage; the setting behavior is unchanged, so no actionable merge-blocking risk remains. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Your free Security trial is over. An organization admin can activate billing to continue. Comment |
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/33033598416. |
|
Deploy-Preview-URL: https://ce-42167.dp.appsmith.com |
Description
In Admin Settings → Authentication → Form login, the signup toggle (
isSignupDisabled) rendered its label from the current value: "Allow only invited users to signup" when signup is disabled, "Allow all users to signup" when enabled. Because the label restated the current state, toggling the switch appeared to change the option itself — a customer looking for the "invited users" option couldn't find it while it was enabled, and open signup kept adding unintended members (and paid seats) to their org.This PR makes the label static — "Allow all users to signup" — so it describes what the setting does: switch ON = anyone can sign up, switch OFF = only invited users can sign up. This matches the static-label pattern of the sibling toggles on the same page ("Enable form login", "Enable email verification") and keeps the accessible name of the switch stable across activation.
Behavior of the setting itself is unchanged; this is label-only.
Call sites checked
toggleTextis only consumed byFieldToggleWithToggleTextinapp/client/src/pages/AdminSettings/FormGroup/Toggle.tsx;isSignupDisabledwas the only setting supplying a value-dependent one.[data-testid='isSignupDisabled']).FormAuthfromce/with no override, so this CE-only change flows to EE via the hourly sync (verified it applies cleanly).Tests
app/client/src/ce/pages/AdminSettings/config/authentication.test.tsx: asserts the label is state-independent and pins the exact wording. Verified red against the pre-fix source, green after.src/pages/AdminSettingsjest scope passes (13 suites, 39 tests).Fixes https://linear.app/appsmith/issue/APP-15855
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/33033481965
Commit: b7d0192
Cypress dashboard.
Tags:
@tag.AllSpec:
Thu, 27 Aug 2026 03:33:10 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Tests