Skip to content

fix(core): harden vercel deploy workflows - #240

Merged
harishsundar-okta merged 2 commits into
mainfrom
fix/security-vercel-deploy-workflows
Apr 7, 2026
Merged

fix(core): harden vercel deploy workflows#240
harishsundar-okta merged 2 commits into
mainfrom
fix/security-vercel-deploy-workflows

Conversation

@harishsundar-okta

@harishsundar-okta harishsundar-okta commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Hardens the Vercel deployment workflows against supply chain attacks and credential information disclosure.

Why

A security review identified three vulnerabilities in the production deployment workflow:

  • Supply chain risk — vercel@latest was used, allowing a compromised future version to execute in CI.
  • Information disclosure — An unnecessary echo statement logged deployment context to the terminal, risking credential exposure.
  • Information disclosure — The Vercel API token was passed via ${{ secrets.VERCEL_TOKEN }} inline string interpolation in a bash script, which can leak the value in logs if the GitHub auto-scrubbing fails to detect it.

What

  • production-deploy.yml: Pinned Vercel CLI from vercel@latest to vercel@39.3.0.
  • production-deploy.yml: Removed the echo "Deploying to Vercel (Production)..." line.
  • production-deploy.yml: Moved VERCEL_TOKEN to a step-level env variable instead of using ${{ secrets.VERCEL_TOKEN }} inline in the run script.
  • preview-deploy.yml: Quoted $VERCEL_TOKEN and $VERCEL_ORG_ID variable references in the deploy command to prevent word-splitting and accidental exposure.

Testing

  • image
  • image

Checklist

@codecov-commenter

codecov-commenter commented Apr 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.64%. Comparing base (1f2c1e5) to head (0d50c66).
⚠️ Report is 49 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files         154      154           
  Lines       13127    13127           
  Branches     1711     1711           
=======================================
  Hits        11637    11637           
  Misses       1490     1490           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harishsundar-okta
harishsundar-okta marked this pull request as ready for review April 7, 2026 11:43
@harishsundar-okta harishsundar-okta added bug Something isn't working Gen AI Indicates that the most of the code in this PR were generated or assisted by generative AI tools. refactor Restructuring existing code and logic to reduce technical debt and improve quality and removed bug Something isn't working labels Apr 7, 2026
Comment thread .github/workflows/production-deploy.yml Outdated
Comment thread .github/workflows/preview-deploy.yml Outdated
Comment thread .github/workflows/production-deploy.yml Outdated
@harishsundar-okta
harishsundar-okta merged commit 40f649d into main Apr 7, 2026
8 checks passed
@harishsundar-okta
harishsundar-okta deleted the fix/security-vercel-deploy-workflows branch April 7, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gen AI Indicates that the most of the code in this PR were generated or assisted by generative AI tools. refactor Restructuring existing code and logic to reduce technical debt and improve quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants