Skip to content

fix(core): harden vercel deploy workflows #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harishsundar-okta merged 2 commits into from
Apr 7, 2026
Merged

fix(core): harden vercel deploy workflows #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f135074
fix(core): harden vercel deploy workflows
harishsundar-okta Apr 7, 2026
0d50c66
fix(core): address pr review feedback
harishsundar-okta Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/preview-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,11 @@ jobs:
run: pnpm docs:api

- name: Install Vercel CLI
run: npm install --global vercel@39.3.0
run: npm install --global vercel@50.40.0

- name: Deploy to Vercel
id: vercel-deploy
run: |
echo "Deploying docs-site to Vercel..."

# Create a completely isolated deployment directory
mkdir -p /tmp/static-deploy

Expand All @@ -79,7 +77,7 @@ jobs:
echo '{"buildCommand":"","installCommand":"","rewrites":[{"source":"/r/:path*","destination":"/api/r?file=:path*"},{"source":"/(.*)","destination":"/index.html"}]}' > /tmp/static-deploy/vercel.json

vercel --version
DEPLOYMENT_URL=$(vercel deploy /tmp/static-deploy --token=$VERCEL_TOKEN --yes --scope=$VERCEL_ORG_ID)
DEPLOYMENT_URL=$(vercel deploy /tmp/static-deploy --token="$VERCEL_TOKEN" --yes --scope="$VERCEL_ORG_ID")
echo "preview-url=$DEPLOYMENT_URL" >> $GITHUB_OUTPUT

- name: Comment PR
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/production-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
run: pnpm build

- name: Install Vercel CLI
run: npm install --global vercel@latest
run: npm install --global vercel@50.40.0

- name: Stage deployment artifacts
run: |
Expand All @@ -56,7 +56,8 @@ jobs:

- name: Deploy to Vercel (Production)
id: deploy
env:
VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }}
run: |
echo "Deploying to Vercel (Production)..."
vercel --version
vercel deploy /tmp/static-deploy --prod --token=${{ secrets.VERCEL_TOKEN }} --yes --scope=$VERCEL_ORG_ID
vercel deploy /tmp/static-deploy --prod --token="$VERCEL_TOKEN" --yes --scope="$VERCEL_ORG_ID"
Loading