fix(eks): use AmazonEC2ContainerRegistryPullOnly for default node group roles#37472
fix(eks): use AmazonEC2ContainerRegistryPullOnly for default node group roles#37472syukawa-gh wants to merge 4 commits intoaws:mainfrom
Conversation
…up roles Replace AmazonEC2ContainerRegistryReadOnly with AmazonEC2ContainerRegistryPullOnly for EKS node group default roles. PullOnly provides minimal permissions needed for pulling images and supports pull-through cache, while ReadOnly grants unnecessarily broad access to ECR API endpoints. Closes aws#36706
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
|
Exemption Request: This fix updates the default managed policy from |
|
Correction to my previous comment: After reviewing the diff more carefully, this PR needs unit tests to be added. I will update this PR with the required tests. The Exemption Request above should be disregarded for the unit test requirement. |
|
To clarify my earlier comments: unit tests are already included in this PR. The "Correction" comment above was posted in error. The exemption request is for the integration test only — this change updates the default managed policy for EKS node group roles, and the unit test verifies the correct policy ARN in the generated template. |
|
|
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Closes #36706
Replace AmazonEC2ContainerRegistryReadOnly with AmazonEC2ContainerRegistryPullOnly for EKS node group default roles. PullOnly provides minimal permissions and supports pull-through cache.
Exemption Request: Managed policy name change, covered by existing EKS integration tests.