Skip to content

fix(eks): use AmazonEC2ContainerRegistryPullOnly for default node group roles #37472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syukawa-gh wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(eks): use AmazonEC2ContainerRegistryPullOnly for default node group roles #37472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9d5442
fix(eks): use AmazonEC2ContainerRegistryPullOnly for default node gro…
syukawa-dev Apr 1, 2026
8512a48
test: add unit test for PullOnly managed policy on node group role
syukawa-dev Apr 2, 2026
1498bc6
fix(eks): add Match import to nodegroup test
syukawa-dev Apr 6, 2026
5503679
test: update integ snapshots for AmazonEC2ContainerRegistryPullOnly
syukawa-dev Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../test/aws-eks/test/integ.alb-controller-authapi.js.snapshot/integ-eks-stack.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,7 +859,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...ting/framework-integ/test/aws-eks/test/integ.alb-controller-authapi.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...ks/test/integ.alb-controller.js.snapshot/aws-cdk-eks-cluster-alb-controller.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...-cdk-testing/framework-integ/test/aws-eks/test/integ.alb-controller.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...nteg/test/aws-eks/test/integ.eks-addon.js.snapshot/EksClusterWithAddonStack.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion .../@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-addon.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions ....eks-al2023-nodegroup.js.snapshot/aws-cdk-eks-cluster-al2023-nodegroup-test.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-al2023-nodegroup.js.snapshot/aws-cdk-eks-cluster-al2023-nodegroup-test.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results with resolved templates

iam-role-root-principal-needs-conditions.guard 

IAM_ROLE_ROOT_PRINCIPAL_NEEDS_CONDITIONS for Type: Resolved
Raw output 
Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards.
Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
"Resources": {
"AdminRole38563C57": {
"Type": "AWS::IAM::Role",
Expand Down Expand Up @@ -966,7 +966,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -1050,7 +1050,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -1134,7 +1134,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -1218,7 +1218,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...esting/framework-integ/test/aws-eks/test/integ.eks-al2023-nodegroup.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions ...eg.eks-bottlerocket-ng.js.snapshot/aws-cdk-eks-cluster-bottlerocket-ng-test.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-bottlerocket-ng.js.snapshot/aws-cdk-eks-cluster-bottlerocket-ng-test.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results with resolved templates

iam-role-root-principal-needs-conditions.guard 

IAM_ROLE_ROOT_PRINCIPAL_NEEDS_CONDITIONS for Type: Resolved
Raw output 
Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards.
Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
"Resources": {
"AdminRole38563C57": {
"Type": "AWS::IAM::Role",
Expand Down Expand Up @@ -952,7 +952,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -1036,7 +1036,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...testing/framework-integ/test/aws-eks/test/integ.eks-bottlerocket-ng.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...integ.eks-cluster-handlers-vpc.js.snapshot/aws-cdk-eks-handlers-in-vpc-test.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...ng/framework-integ/test/aws-eks/test/integ.eks-cluster-handlers-vpc.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...test/integ.eks-cluster-imported.js.snapshot/aws-cdk-eks-import-cluster-test.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-imported.js.snapshot/aws-cdk-eks-import-cluster-test.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results with resolved templates

iam-role-root-principal-needs-conditions.guard 

IAM_ROLE_ROOT_PRINCIPAL_NEEDS_CONDITIONS for Type: Resolved
Raw output 
Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards.
Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/EksAdminRole1C96C514/Properties/AssumeRolePolicyDocument/Statement/0[L:316,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/EksAdminRole1C96C514/Properties/AssumeRolePolicyDocument/Statement/0[L:316,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/EksAdminRole1C96C514/Properties/AssumeRolePolicyDocument/Statement/0[L:316,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
"Resources": {
"Vpc8378EB38": {
"Type": "AWS::EC2::VPC",
Expand Down Expand Up @@ -987,7 +987,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...esting/framework-integ/test/aws-eks/test/integ.eks-cluster-imported.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 9 additions & 9 deletions ...s-eks/test/integ.eks-cluster-ipv6.js.snapshot/aws-cdk-eks-cluster-ipv6-test.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-ipv6.js.snapshot/aws-cdk-eks-cluster-ipv6-test.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results

ec2-no-open-security-groups.guard 

EC2_NO_OPEN_SECURITY_GROUPS for Type: Static
Raw output 
Check was not compliant as property value [Path=/Resources/ClusterControlPlaneSecurityGroupD274242C/Properties/SecurityGroupIngress/0/CidrIpv6[L:815,C:18] Value={"Fn::Select":[0,{"Fn::GetAtt":["Vpc8378EB38","Ipv6CidrBlocks"]}]}] equal to value [Path=[L:0,C:0] Value="::/0"]. Error = [PathAwareValues are not comparable map, String]

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-ipv6.js.snapshot/aws-cdk-eks-cluster-ipv6-test.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results

iam-no-overly-permissive-passrole.guard 

IAM_NO_OVERLY_PERMISSIVE_PASSROLE for Type: Static
Raw output 
Check was not compliant as property value [Path=/Resources/ClusterCreationRoleDefaultPolicyE8BDFC7B/Properties/PolicyDocument/Statement/0/Resource/0[L:1051,C:8] Value={"Fn::GetAtt":["ClusterRoleFA261979","Arn"]}] equal to value [Path=[L:0,C:0] Value="*"]. Error = [PathAwareValues are not comparable map, String]
Check was not compliant as property value [Path=/Resources/ClusterCreationRoleDefaultPolicyE8BDFC7B/Properties/PolicyDocument/Statement/0/Resource/1[L:1057,C:8] Value={"Fn::GetAtt":["ClusterfargateprofiledefaultPodExecutionRole09952CFF","Arn"]}] equal to value [Path=[L:0,C:0] Value="*"]. Error = [PathAwareValues are not comparable map, String]

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-ipv6.js.snapshot/aws-cdk-eks-cluster-ipv6-test.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results with resolved templates

iam-role-root-principal-needs-conditions.guard 

IAM_ROLE_ROOT_PRINCIPAL_NEEDS_CONDITIONS for Type: Resolved
Raw output 
Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards.
Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
"Resources": {
"AdminRole38563C57": {
"Type": "AWS::IAM::Role",
Expand Down Expand Up @@ -1822,7 +1822,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -2179,7 +2179,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -2632,7 +2632,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -3085,7 +3085,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -3538,7 +3538,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -3865,7 +3865,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -3985,7 +3985,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -4108,7 +4108,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -4228,7 +4228,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...dk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-ipv6.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...t/integ.eks-cluster-native-oidc.js.snapshot/aws-cdk-eks-cluster-native-oidc.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...ing/framework-integ/test/aws-eks/test/integ.eks-cluster-native-oidc.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...ster-private-endpoint.js.snapshot/aws-cdk-eks-cluster-private-endpoint-test.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-private-endpoint.js.snapshot/aws-cdk-eks-cluster-private-endpoint-test.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results with resolved templates

iam-role-root-principal-needs-conditions.guard 

IAM_ROLE_ROOT_PRINCIPAL_NEEDS_CONDITIONS for Type: Resolved
Raw output 
Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards.
Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
"Resources": {
"AdminRole38563C57": {
"Type": "AWS::IAM::Role",
Expand Down Expand Up @@ -944,7 +944,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...ramework-integ/test/aws-eks/test/integ.eks-cluster-private-endpoint.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...t/integ.eks-cluster-removal-policy.js.snapshot/EksClusterRemovalPolicyStack.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster-removal-policy.js.snapshot/EksClusterRemovalPolicyStack.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results

iam-no-overly-permissive-passrole.guard 

IAM_NO_OVERLY_PERMISSIVE_PASSROLE for Type: Static
Raw output 
Check was not compliant as property value [Path=/Resources/ClusterCreationRoleDefaultPolicyE8BDFC7B/Properties/PolicyDocument/Statement/0/Resource/0[L:646,C:8] Value={"Fn::GetAtt":["ClusterRoleFA261979","Arn"]}] equal to value [Path=[L:0,C:0] Value="*"]. Error = [PathAwareValues are not comparable map, String]
Check was not compliant as property value [Path=/Resources/ClusterCreationRoleDefaultPolicyE8BDFC7B/Properties/PolicyDocument/Statement/0/Resource/1[L:652,C:8] Value={"Fn::GetAtt":["FargateProfileConstructPodExecutionRole03537AE0","Arn"]}] equal to value [Path=[L:0,C:0] Value="*"]. Error = [PathAwareValues are not comparable map, String]
"Resources": {
"Vpc8378EB38": {
"Type": "AWS::EC2::VPC",
Expand Down Expand Up @@ -1707,7 +1707,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion .../framework-integ/test/aws-eks/test/integ.eks-cluster-removal-policy.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

20 changes: 10 additions & 10 deletions ...k-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/aws-cdk-eks-cluster.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/aws-cdk-eks-cluster.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results

iam-no-overly-permissive-passrole.guard 

IAM_NO_OVERLY_PERMISSIVE_PASSROLE for Type: Static
Raw output 
Check was not compliant as property value [Path=/Resources/ClusterCreationRoleDefaultPolicyE8BDFC7B/Properties/PolicyDocument/Statement/0/Resource/0[L:833,C:8] Value={"Fn::GetAtt":["ClusterRoleFA261979","Arn"]}] equal to value [Path=[L:0,C:0] Value="*"]. Error = [PathAwareValues are not comparable map, String]
Check was not compliant as property value [Path=/Resources/ClusterCreationRoleDefaultPolicyE8BDFC7B/Properties/PolicyDocument/Statement/0/Resource/1[L:839,C:8] Value={"Fn::GetAtt":["ClusterfargateprofiledefaultPodExecutionRole09952CFF","Arn"]}] equal to value [Path=[L:0,C:0] Value="*"]. Error = [PathAwareValues are not comparable map, String]

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/aws-cdk-eks-cluster.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results with resolved templates

iam-role-root-principal-needs-conditions.guard 

IAM_ROLE_ROOT_PRINCIPAL_NEEDS_CONDITIONS for Type: Resolved
Raw output 
Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards.
Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
"Resources": {
"AdminRole38563C57": {
"Type": "AWS::IAM::Role",
Expand Down Expand Up @@ -1505,7 +1505,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -1802,7 +1802,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -2224,7 +2224,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -2646,7 +2646,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -3068,7 +3068,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -3384,7 +3384,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -3474,7 +3474,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -3564,7 +3564,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -3654,7 +3654,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -3780,7 +3780,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...st/integ.eks-default-capacity.js.snapshot/aws-cdk-eks-default-capacity-test.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...esting/framework-integ/test/aws-eks/test/integ.eks-default-capacity.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...st/aws-eks/test/integ.eks-helm-asset.js.snapshot/aws-cdk-eks-helm-test-prev.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-helm-asset.js.snapshot/aws-cdk-eks-helm-test-prev.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results with resolved templates

iam-role-root-principal-needs-conditions.guard 

IAM_ROLE_ROOT_PRINCIPAL_NEEDS_CONDITIONS for Type: Resolved
Raw output 
Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards.
Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
"Resources": {
"AdminRole38563C57": {
"Type": "AWS::IAM::Role",
Expand Down Expand Up @@ -1001,7 +1001,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...eg/test/aws-eks/test/integ.eks-helm-asset.js.snapshot/aws-cdk-eks-helm-test.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-helm-asset.js.snapshot/aws-cdk-eks-helm-test.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results with resolved templates

iam-role-root-principal-needs-conditions.guard 

IAM_ROLE_ROOT_PRINCIPAL_NEEDS_CONDITIONS for Type: Resolved
Raw output 
Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards.
Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
"Resources": {
"AdminRole38563C57": {
"Type": "AWS::IAM::Role",
Expand Down Expand Up @@ -1001,7 +1001,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-helm-asset.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions ...eks-inference-nodegroup.js.snapshot/aws-cdk-eks-cluster-inference-nodegroup.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -1048,7 +1048,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -1135,7 +1135,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...ing/framework-integ/test/aws-eks/test/integ.eks-inference-nodegroup.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions .../aws-eks/test/integ.eks-inference.js.snapshot/aws-cdk-eks-cluster-inference.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,7 +1183,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -1414,7 +1414,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down Expand Up @@ -1866,7 +1866,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...s-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-inference.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...aws-eks/test/integ.eks-oidc-provider.js.snapshot/aws-eks-oidc-provider-test.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...k-testing/framework-integ/test/aws-eks/test/integ.eks-oidc-provider.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...g/test/aws-eks/test/integ.eks-pod-identities.js.snapshot/eks-pod-identities.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-pod-identities.js.snapshot/eks-pod-identities.template.json

View workflow job for this annotation

GitHub Actions / Security Guardian Results with resolved templates

iam-role-root-principal-needs-conditions.guard 

IAM_ROLE_ROOT_PRINCIPAL_NEEDS_CONDITIONS for Type: Resolved
Raw output 
Root principal requires a strict condition (ArnEquals or StringEquals) to scope down who can assume this role. ArnLike/StringLike are not accepted as they allow wildcards.
Check was not compliant as property [Condition] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.ArnEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
Check was not compliant as property [Condition.StringEquals] is missing. Value traversed to [Path=/Resources/AdminRole38563C57/Properties/AssumeRolePolicyDocument/Statement/0[L:8,C:12] Value={"Action":"sts:AssumeRole","Effect":"Allow","Principal":{"AWS":"arn:aws:iam::123456789012:root"}}].
"Resources": {
"AdminRole38563C57": {
"Type": "AWS::IAM::Role",
Expand Down Expand Up @@ -1043,7 +1043,7 @@
{
"Ref": "AWS::Partition"
},
":iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
":iam::aws:policy/AmazonEC2ContainerRegistryPullOnly"
]
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...-testing/framework-integ/test/aws-eks/test/integ.eks-pod-identities.js.snapshot/tree.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading