Skip to content

chore(CI): Fix daily CI#832

Merged
lucasmcdonald3 merged 7 commits intomasterfrom
lucmcdon-fixDailyCI
Feb 17, 2026
Merged

chore(CI): Fix daily CI#832
lucasmcdonald3 merged 7 commits intomasterfrom
lucmcdon-fixDailyCI

Conversation

@lucasmcdonald3
Copy link
Copy Markdown
Contributor

@lucasmcdonald3 lucasmcdonald3 commented Feb 11, 2026

Issue #, if available:

Description of changes:

  1. Fix GHA workflow permissions
  2. Replace install_name_tool -add_rpath commands that were causing macOS header padding errors with more robust -Wl,-rpath commands

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

rishav-karanjit and others added 3 commits February 10, 2026 09:45
Replace post-link install_name_tool calls with -Wl,-rpath flags during linking to avoid Mach-O header space issues on macos-latest-large runners.
@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner February 11, 2026 21:41
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to continuous-integration February 11, 2026 21:42 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to continuous-integration February 11, 2026 21:42 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 changed the base branch from fixDailyCI to master February 11, 2026 21:42
@lucasmcdonald3 lucasmcdonald3 changed the title Fix macOS install_name_tool header padding error chore(CI): Fix daily CI Feb 11, 2026
@rishav-karanjit rishav-karanjit mentioned this pull request Feb 12, 2026
1 task
Comment thread .github/workflows/daily_ci.yml Outdated
contents: read
pull_request:
paths:
.github/workflows/daily_ci.yml
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in In GitHub Actions, paths should be a YAML list. Right now it’s a scalar string.

Change to: - .github/workflows/daily_ci.yml

# This workflow runs every weekday at 15:00 UTC (8AM PDT)
name: Daily CI

permissions:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to scope permissions per job (principle of least privilege):

permissions:
contents: read

jobs:
codebuild:
permissions:
id-token: write
contents: read

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better suggestion: jobs:
codebuild:
if: github.event_name == 'pull_request' || github.repository_owner == 'aws'
permissions:
contents: read
id-token: write
uses: ./.github/workflows/codebuild.yml
secrets: inherit

Comment thread .github/workflows/push.yml Outdated

permissions:
contents: read
id-token: write
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

permissions:
contents: read

jobs:
codebuild:
permissions:
contents: read
id-token: write
uses: ./.github/workflows/codebuild.yml
secrets: inherit

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of this commit the file call:

proof_ci.yaml (yaml)

other workflows are .yml

@lucasmcdonald3 lucasmcdonald3 temporarily deployed to continuous-integration February 13, 2026 19:29 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to continuous-integration February 13, 2026 19:29 — with GitHub Actions Inactive
Lucas McDonald added 2 commits February 13, 2026 11:42
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to continuous-integration February 13, 2026 20:04 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 temporarily deployed to continuous-integration February 13, 2026 20:04 — with GitHub Actions Inactive
@lucasmcdonald3 lucasmcdonald3 merged commit b29a222 into master Feb 17, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants