Conversation
Replace post-link install_name_tool calls with -Wl,-rpath flags during linking to avoid Mach-O header space issues on macos-latest-large runners.
| contents: read | ||
| pull_request: | ||
| paths: | ||
| .github/workflows/daily_ci.yml |
There was a problem hiding this comment.
I think in In GitHub Actions, paths should be a YAML list. Right now it’s a scalar string.
Change to: - .github/workflows/daily_ci.yml
| # This workflow runs every weekday at 15:00 UTC (8AM PDT) | ||
| name: Daily CI | ||
|
|
||
| permissions: |
There was a problem hiding this comment.
better to scope permissions per job (principle of least privilege):
permissions:
contents: read
jobs:
codebuild:
permissions:
id-token: write
contents: read
There was a problem hiding this comment.
Better suggestion: jobs:
codebuild:
if: github.event_name == 'pull_request' || github.repository_owner == 'aws'
permissions:
contents: read
id-token: write
uses: ./.github/workflows/codebuild.yml
secrets: inherit
|
|
||
| permissions: | ||
| contents: read | ||
| id-token: write |
There was a problem hiding this comment.
permissions:
contents: read
jobs:
codebuild:
permissions:
contents: read
id-token: write
uses: ./.github/workflows/codebuild.yml
secrets: inherit
There was a problem hiding this comment.
Not part of this commit the file call:
proof_ci.yaml (yaml)
other workflows are .yml
Issue #, if available:
Description of changes:
install_name_tool -add_rpathcommands that were causing macOS header padding errors with more robust-Wl,-rpathcommandsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: