Skip to content

chore(CI): Fix daily CI #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucasmcdonald3 merged 7 commits into from
Feb 17, 2026
Merged

chore(CI): Fix daily CI #832

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c86fad8
m
rishav-karanjit Feb 10, 2026
cf53649
empty commit
rishav-karanjit Feb 10, 2026
6924585
Fix macOS install_name_tool header padding error
Feb 11, 2026
b8dcb49
m
Feb 13, 2026
381c290
m
Feb 13, 2026
f5f4588
m
Feb 13, 2026
dc3f3ee
m
Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/daily_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
# This workflow runs every weekday at 15:00 UTC (8AM PDT)
name: Daily CI

permissions:
Copy link
Copy Markdown

@mahnushm mahnushm Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to scope permissions per job (principle of least privilege):

permissions:
contents: read

jobs:
codebuild:
permissions:
id-token: write
contents: read

Copy link
Copy Markdown

@mahnushm mahnushm Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better suggestion: jobs:
codebuild:
if: github.event_name == 'pull_request' || github.repository_owner == 'aws'
permissions:
contents: read
id-token: write
uses: ./.github/workflows/codebuild.yml
secrets: inherit

contents: read
id-token: write

on:
schedule:
- cron: "00 15 * * 1-5"

permissions:
contents: read
pull_request:
paths:
.github/workflows/daily_ci.yml
Copy link
Copy Markdown

@mahnushm mahnushm Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in In GitHub Actions, paths should be a YAML list. Right now it’s a scalar string.

Change to: - .github/workflows/daily_ci.yml


jobs:
codebuild:
Expand All @@ -18,7 +22,7 @@ jobs:
[
codebuild,
]
if: ${{ failure() }}
if: ${{ failure() && github.event_name == 'schedule' }}
uses: aws/aws-cryptographic-material-providers-library/.github/workflows/slack-notification.yml@main
with:
message: "Daily CI failed on `${{ github.repository }}`. View run: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/push.yml
View file
Open in desktop
Copy link
Copy Markdown

@mahnushm mahnushm Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of this commit the file call:

proof_ci.yaml (yaml)

other workflows are .yml

Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:

permissions:
contents: read
id-token: write
Copy link
Copy Markdown

@mahnushm mahnushm Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

permissions:
contents: read

jobs:
codebuild:
permissions:
contents: read
id-token: write
uses: ./.github/workflows/codebuild.yml
secrets: inherit


jobs:
clang-format:
Expand Down
6 changes: 3 additions & 3 deletions tests/TestVectors/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
test_vectors: *.cpp *.h
g++ -g -ggdb --std=c++17 -o test_vectors -I../../include/ \
-Wl,-rpath,../../build-aws-encryption-sdk-c/Debug/ \
-Wl,-rpath,../../build-aws-encryption-sdk-c/aws-encryption-sdk-cpp/Debug/ \
-Wl,-rpath,../../install/lib/ \
base64.cpp do_decrypt.cpp do_encrypt.cpp parse_encrypt.cpp parse_keys.cpp test_vectors.cpp \
-I/opt/homebrew/include/ -L/opt/homebrew/lib/ \
-I../../install/include/ -L../../install/lib/ -I ../../aws-encryption-sdk-cpp/include/ \
../../build-aws-encryption-sdk-c/Debug/libaws-encryption-sdk.dylib \
../../build-aws-encryption-sdk-c/aws-encryption-sdk-cpp/Debug/libaws-encryption-sdk-cpp.dylib \
-laws-cpp-sdk-core -laws-cpp-sdk-kms -laws-c-common -lcrypto
install_name_tool -add_rpath ../../build-aws-encryption-sdk-c/Debug/ test_vectors
install_name_tool -add_rpath ../../build-aws-encryption-sdk-c/aws-encryption-sdk-cpp/Debug/ test_vectors
install_name_tool -add_rpath ../../install/lib/ test_vectors

test_vectors_unix: *.cpp *.h
g++ -g -ggdb --std=c++17 -o test_vectors -I../../include/ \
Expand Down
Loading