Skip to content

26.1 Update - #160

Merged
axieum merged 9 commits into
axieum:mainfrom
BytelyPlay:26.1-update
Apr 27, 2026
Merged

26.1 Update#160
axieum merged 9 commits into
axieum:mainfrom
BytelyPlay:26.1-update

Conversation

@BytelyPlay

@BytelyPlay BytelyPlay commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

I updated this modification to 26.1, honestly, it's been a while since I lasted used Architectury, I tested this in the developer environment, since I couldn't figure out how to get a release jar... (gradlew clean build produced a -dev-shadow jar, that, for some reason didn't apply access wideners)
I made this update for my fork, so don't worry if you don't want to merge this.
I didn't thoroughly test this, but I did a quick test.

Also quick credit to Cloth Config, I looked at how they did it.
It helped quite a bit since I didn't know the new plugin names, other than that, my work is independent.

Closes #159

@github-actions github-actions Bot added build Improvements or additions to the build process fabric Improvements or additions to the Fabric distribution neoforge Improvements or additions to the NeoForge distribution common labels Apr 20, 2026

@axieum axieum left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, you're a legend - thank you.

Comment thread build.gradle
@BytelyPlay
BytelyPlay requested a review from axieum April 21, 2026 09:40
@BytelyPlay

Copy link
Copy Markdown
Contributor Author

By the way, I wanted to say, the reason the build failed was because it was using JDK 21 and not 25.
That would require a change to the workflows.

@github-actions github-actions Bot added the ci Improvements or additions to deployments label Apr 23, 2026
@axieum

axieum commented Apr 23, 2026

Copy link
Copy Markdown
Owner

Still some work to do with access wideners by the looks of it. I'm getting this error in production:

[21:48:13] [pool-5-thread-1] [Auth Me/ERROR]: Could not login via Microsoft!
java.util.concurrent.CompletionException: java.lang.IllegalAccessError: class me.axieum.mcmod.authme.api.util.SessionUtils tried to access private method 'void com.mojang.realmsclient.client.RealmsClient.<init>(java.lang.String, java.lang.String, net.minecraft.client.Minecraft)' (me.axieum.mcmod.authme.api.util.SessionUtils and com.mojang.realmsclient.client.RealmsClient are in unnamed module of loader 'knot' @3891771e)
        at java.base/java.util.concurrent.CompletableFuture.wrapInCompletionException(Unknown Source)
        at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(Unknown Source)
        at java.base/java.util.concurrent.CompletableFuture.completeThrowable(Unknown Source)
        at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source)
        at java.base/java.util.concurrent.CompletableFuture.postComplete(Unknown Source)
        at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.lang.IllegalAccessError: class me.axieum.mcmod.authme.api.util.SessionUtils tried to access private method 'void com.mojang.realmsclient.client.RealmsClient.<init>(java.lang.String, java.lang.String, net.minecraft.client.Minecraft)' (me.axieum.mcmod.authme.api.util.SessionUtils and com.mojang.realmsclient.client.RealmsClient are in unnamed module of loader 'knot' @3891771e)
        at knot//me.axieum.mcmod.authme.api.util.SessionUtils.setUser(SessionUtils.java:102)
        at knot//me.axieum.mcmod.authme.api.gui.screen.MicrosoftAuthScreen.lambda$init$7(MicrosoftAuthScreen.java:128)
        ... 6 more

Might pick this up again either tomorrow or on the weekend.

@BytelyPlay

BytelyPlay commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

Oh yeah I completely forgot, I realized this in my fork, and I replaced access wideners with accessors... I can do the same thing here if you'd like... But I'll try to get access wideners to work first, since that's a cleaner solution.

@BytelyPlay

BytelyPlay commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

I can't get the Access Wideners to work, and it seems like neither can you, I'd recommend just using Accessors. If you want, I can make the project use Accessors instead.
It could be a temporary solution I guess...
The only thing I can offer you for trying to get the Access Wideners to work, is that it's very likely that the fabric.mod.json has something wrong or the Fabric loader has something wrong.

@BytelyPlay

BytelyPlay commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

I forgot to add the things I tried and that didn't work:
Downgrading the Fabric loader version (in the environment, not as a dependency)
Unzipping the jar to make sure everything is there.
Checking out the fabric.mod.json spec, seems to be fine.
Testing to see if I can access the "realmsClientInstance" field, I can't.
Tried running the "validateAccessWideners" Gradle configuration.

There is no log that helps me in the production environment, although the dev environment works wonders.
I'll just replace the Access Wideners with Accessors, since that's the recommended method anyway.

@axieum
axieum merged commit 48d6961 into axieum:main Apr 27, 2026
2 checks passed
axieum added a commit that referenced this pull request Apr 27, 2026
Release-As: 9.1.0+26.1
Co-authored-by: Jonathan Hiles <jonathan@hil.es>
@axieum

axieum commented Apr 27, 2026

Copy link
Copy Markdown
Owner

Thanks heaps @BytelyPlay for assisting with this release! ❤️

@BytelyPlay

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Improvements or additions to the build process ci Improvements or additions to deployments common fabric Improvements or additions to the Fabric distribution neoforge Improvements or additions to the NeoForge distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

26.1 Update

2 participants