26.1 Update - #160
Conversation
axieum
left a comment
There was a problem hiding this comment.
This is great, you're a legend - thank you.
…sName instead of archivesBaseName.
|
By the way, I wanted to say, the reason the build failed was because it was using JDK 21 and not 25. |
|
Still some work to do with access wideners by the looks of it. I'm getting this error in production: Might pick this up again either tomorrow or on the weekend. |
|
Oh yeah I completely forgot, I realized this in my fork, and I replaced access wideners with accessors... I can do the same thing here if you'd like... But I'll try to get access wideners to work first, since that's a cleaner solution. |
|
I can't get the Access Wideners to work, and it seems like neither can you, I'd recommend just using Accessors. If you want, I can make the project use Accessors instead. |
|
I forgot to add the things I tried and that didn't work: There is no log that helps me in the production environment, although the dev environment works wonders. |
Release-As: 9.1.0+26.1 Co-authored-by: Jonathan Hiles <jonathan@hil.es>
|
Thanks heaps @BytelyPlay for assisting with this release! ❤️ |
|
Thanks! |
I updated this modification to 26.1, honestly, it's been a while since I lasted used Architectury, I tested this in the developer environment, since I couldn't figure out how to get a release jar... (gradlew clean build produced a -dev-shadow jar, that, for some reason didn't apply access wideners)
I made this update for my fork, so don't worry if you don't want to merge this.
I didn't thoroughly test this, but I did a quick test.
Also quick credit to Cloth Config, I looked at how they did it.
It helped quite a bit since I didn't know the new plugin names, other than that, my work is independent.
Closes #159