Open
Conversation
It was failing with older OS versions that still use resin_supervisor as a container. The script was not falling back to `resin_supervisor` when inspecting the container Change-type: patch
Ordering of results seems to be system dependent, so we sort entries before comparing.
kb2ma
reviewed
Apr 18, 2026
kb2ma
left a comment
kb2ma
left a comment
There was a problem hiding this comment.
Also, how is the test fix related to this PR?
|
|
||
| find_docker_image() { | ||
| docker inspect "$1" 2>/dev/null | jq -r '.[].Image' | ||
| img=$(docker inspect "$1" 2>/dev/null | jq -r '.[].Image') |
There was a problem hiding this comment.
Why is the binary named "docker" instead of "balena" if it runs on a device?
Contributor
Author
There was a problem hiding this comment.
because it uses the docker CLI from within the helios container
Contributor
Author
It's not, but without the fix tests were not passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was failing with older OS versions that still use resin_supervisor as a container. The script was not falling back to
resin_supervisorwhen inspecting the containeIncludes a fix for a flaky test without which the PR cannot be merged
Change-type: patch