Skip to content

Fix supervisor takeover script #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pipex wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −2
Open

Fix supervisor takeover script #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf22f22
Fix supervisor takeover script
pipex Apr 17, 2026
e78dea2
Fix flaky helios-store test
pipex Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion helios-store/src/document.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,10 +1141,11 @@ mod tests {
);

// list_at with a pattern scoped to the base
let paths = store
let mut paths = store
.list_at(Some(Path::new("a")), Some("*.json"))
.await
.unwrap();
paths.sort();
assert_eq!(
paths,
vec![PathBuf::from("1.json"), PathBuf::from("2.json")]
Expand Down
3 changes: 2 additions & 1 deletion scripts/setup-supervisor.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ wait_for_port_release() {
}

find_docker_image() {
docker inspect "$1" 2>/dev/null | jq -r '.[].Image'
img=$(docker inspect "$1" 2>/dev/null | jq -r '.[].Image')
Copy link
Copy Markdown

@kb2ma kb2ma Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the binary named "docker" instead of "balena" if it runs on a device?

Copy link
Copy Markdown
Contributor Author

@pipex pipex Apr 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it uses the docker CLI from within the helios container

[ -n "$img" ] && echo "$img"
}

find_db_dir() {
Expand Down
Loading