Fix error message not being embedded if step is Status.error#98
Merged
Fix error message not being embedded if step is Status.error#98
Conversation
This deserves better rewrite. We should not check `status == Status.failed` but rather `status in failed_statuses` or `status not in success_statuses`. But that is for another rewrite, hotfixing by replacing error to failed for now.
Member
|
Mmh, I am just curious: SEE ALSO: |
Collaborator
|
We were not aware of that method, but were thinking about a way to do just that. Thank you. In next update we will do it with this method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deserves better rewrite. We should not check
status == Status.failedbut ratherstatus in failed_statusesorstatus not in success_statuses. But that is for another rewrite, hotfixing by replacing error to failed for now.