Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
behave-html-pretty-formatter 1.15.1
===================================
Fix not embedding error message if step is Status.error.


behave-html-pretty-formatter 1.15
=================================
Fix behave version to 1.3.0.
Expand Down
21 changes: 14 additions & 7 deletions behave_html_pretty_formatter/html_pretty.py
Original file line number Diff line number Diff line change
Expand Up @@ -503,22 +503,26 @@ def report_error(self, behave_obj):
"""
Embeds error message and traceback.
"""
if not behave_obj.error_message:

err = behave_obj.error_message
if not err:
err = behave_obj.exception
if not err:
return
if self.reported_error:
if self.reported_error.data == behave_obj.error_message:
if self.reported_error.data == err:
return
if self.reported_error.data in behave_obj.error_message:
if self.reported_error.data in err:
# Do not update traceback, as behave saves only first traceback.
self.reported_error.set_data(
"text",
behave_obj.error_message,
err,
"Error Message",
)
return
self.reported_error = Embed("text", behave_obj.error_message, "Error Message")
self.reported_error = Embed("text", err, "Error Message")
self.embed(self.reported_error)
if "Traceback" not in behave_obj.error_message:
if "Traceback" not in err:
self.embed(
Embed(
"text",
Expand Down Expand Up @@ -634,8 +638,11 @@ def add_result(self, result):
if hasattr(Status, "hook_error") and self.status is Status.hook_error:
self.status = Status.failed

if hasattr(Status, "error") and self.status is Status.error:
self.status = Status.failed

# If the step has error message and step failed, set the error message.
if result.error_message and self.status is Status.failed:
if (result.error_message or result.exception) and self.status is Status.failed:
self.scenario.report_error(result)

# If the step is undefined use the behave function to provide
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "behave-html-pretty-formatter"
version = "1.15"
version = "1.15.1"
description = "Pretty HTML Formatter for Behave"
readme = "README.md"
license = {file = "LICENSE"}
Expand Down
Loading