Retry flash dismissal until it lands, instead of clicking once - #4034
Closed
sethherr wants to merge 1 commit into
Closed
Retry flash dismissal until it lands, instead of clicking once#4034sethherr wants to merge 1 commit into
sethherr wants to merge 1 commit into
Conversation
ui--alert wires its close action in `connect` and application.js lazy loads controllers, so a click landing before that module arrives hits a button with no listener and is swallowed. Every caller dismisses right after a page load, which is when that's most likely -- under CPU load it failed 1 run in 8. Click again until the region clears, the way open_modal already handles the same race. Presence is asserted up front rather than by `minimum: 1` inside the loop, so a retry can't raise a fresh ExpectationNotMet when the region clears between the probe and the lookup. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
Solving with #4031 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dismiss_flash_messagesclicked each close button once, then waited 10s for the region to clear. Butui--alertwires its close action inconnectandapplication.jslazy loads controllers, so a click landing before that module arrives hits a button with no listener and is silently swallowed — and every caller dismisses right after a page load, which is exactly when that's most likely. Under CPU load it failed 1 run in 8.open_modalalready handles the same lazy-load race a few lines up. Same ~10s ceiling; under the load that reproduced the failure, 16 runs (80 dismissals) came back clean.minimum: 1inside the loop, so a retry can't raise a freshExpectationNotMetwhen the region clears between the probe and the lookup.retry_on_detachwraps the query rather than one click, so it re-finds instead of re-clicking a node that's already gone.