Skip to content

Retry flash dismissal until it lands, instead of clicking once - #4034

Closed
sethherr wants to merge 1 commit into
mainfrom
sethherr/tel-aviv-v3
Closed

Retry flash dismissal until it lands, instead of clicking once#4034
sethherr wants to merge 1 commit into
mainfrom
sethherr/tel-aviv-v3

Conversation

@sethherr

@sethherr sethherr commented Aug 4, 2026

Copy link
Copy Markdown
Member

dismiss_flash_messages clicked each close button once, then waited 10s for the region to clear. But ui--alert wires its close action in connect and application.js lazy loads controllers, so a click landing before that module arrives hits a button with no listener and is silently swallowed — and every caller dismisses right after a page load, which is exactly when that's most likely. Under CPU load it failed 1 run in 8.

  • Click again until the region clears, the way open_modal already handles the same lazy-load race a few lines up. Same ~10s ceiling; under the load that reproduced the failure, 16 runs (80 dismissals) came back clean.
  • Presence is asserted up front instead of by minimum: 1 inside the loop, so a retry can't raise a fresh ExpectationNotMet when the region clears between the probe and the lookup. retry_on_detach wraps the query rather than one click, so it re-finds instead of re-clicking a node that's already gone.

ui--alert wires its close action in `connect` and application.js lazy
loads controllers, so a click landing before that module arrives hits a
button with no listener and is swallowed. Every caller dismisses right
after a page load, which is when that's most likely -- under CPU load it
failed 1 run in 8.

Click again until the region clears, the way open_modal already handles
the same race. Presence is asserted up front rather than by `minimum: 1`
inside the loop, so a retry can't raise a fresh ExpectationNotMet when
the region clears between the probe and the lookup.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@sethherr

sethherr commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Solving with #4031

@sethherr sethherr closed this Aug 4, 2026
@sethherr
sethherr deleted the sethherr/tel-aviv-v3 branch August 4, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant