Skip to content

Retry flash dismissal until it lands, instead of clicking once #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sethherr wants to merge 1 commit into from
+10 −4
Closed

Retry flash dismissal until it lands, instead of clicking once #4034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions spec/support/system_spec_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,16 @@ def open_modal(trigger, attempts: 5)
end

# Flash messages are fixed position, so an undismissed one intercepts clicks on
# whatever it overlays. Wait out the dismiss transition before moving on.
def dismiss_flash_messages(wait: 10)
all("#flash-messages [aria-label='Close']", minimum: 1).each(&:click)
expect(page).to have_no_css("#flash-messages [role='alert']", wait:)
# whatever it overlays. Like open_modal, ui--alert wires its close action in
# `connect`, so a click landing before that lazy loaded controller arrives does
# nothing -- click again until the region clears.
def dismiss_flash_messages(attempts: 10)
expect(page).to have_css("#flash-messages [role='alert']")
attempts.times do
retry_on_detach { all("#flash-messages [aria-label='Close']", wait: 0).each(&:click) }
return if page.has_no_css?("#flash-messages [role='alert']", wait: 1)
end
raise "#flash-messages never cleared after #{attempts} dismiss clicks"
end

private
Expand Down