Add prefix: eccDNA - #1366
Conversation
| "github_request_issue": 1366, | ||
| "homepage": "https://lcbb.swjtu.edu.cn/scEccDNAdb/", | ||
| "name": "Single Cell ECC DNA Database", | ||
| "pattern": "^ecDNA_[a-z]+_\\d+$", |
There was a problem hiding this comment.
it's surprising that the resource is called eccdna but the identifier has ecDNA with one fewer c
There was a problem hiding this comment.
For future reference, there are two types of entries: ecDNA (extrachromosomal DNA) and eccDNA (extrachromosomal circular DNA) so the ID pattern makes sense. I added an extra example to show both types.
There was a problem hiding this comment.
There is a problem: for the eccDNA_* case:
for example in entry.example_extras:
with self.subTest(prefix=prefix, identifier=example):
> self.assertEqual(entry.standardize_identifier(example), example)
E AssertionError: 'hsa_35832' != 'eccDNA_hsa_35832'
E - hsa_35832
E + eccDNA_hsa_35832
This has to do with some core code in standardize_identifier that automatically strips off the prefix if followed by a _ at
bioregistry/src/bioregistry/schema/struct.py
Lines 1965 to 1966 in 36cad81
There was a problem hiding this comment.
Set "banana_peel": "", to get around this
There was a problem hiding this comment.
Unfortunately _ is hard-coded as an additional potential banana peel here:
bioregistry/src/bioregistry/schema/struct.py
Line 1960 in 36cad81
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
==========================================
+ Coverage 42.51% 46.27% +3.76%
==========================================
Files 117 118 +1
Lines 8327 8302 -25
Branches 1963 1357 -606
==========================================
+ Hits 3540 3842 +302
+ Misses 4582 4275 -307
+ Partials 205 185 -20 ☔ View full report in Codecov by Sentry. |
| "example": "ecDNA_hsa_01", | ||
| "github_request_issue": 1366, | ||
| "homepage": "https://lcbb.swjtu.edu.cn/scEccDNAdb/", | ||
| "name": "Single Cell ECC DNA Database", |
There was a problem hiding this comment.
please write out non-obvious acronyms like ECC in full in the title
| "name": "Nalika Palayoor", | ||
| "orcid": "0009-0008-8406-631X" | ||
| }, | ||
| "description": "scEccDNAdb is a database of single cell eccDNA entries of human and mouse samples, each with a unique identifier and features such as oncogenes, enhancers, and structural variants.", |
There was a problem hiding this comment.
what is an eccDNA? why do we care about them?


This pull request curates a new prefix eccDNA, which is a database based on single-cell whole genome sequencing data. This PR adds necessary metadata to bioregistry.json and adds the curated paper to currated_papers.tsv
https://pubmed.ncbi.nlm.nih.gov/39693568/