Skip to content

Add prefix: phagedive - #1454

Merged
bgyori merged 7 commits into
biopragmatics:mainfrom
nagutm:phagedive
Mar 29, 2025
Merged

Add prefix: phagedive#1454
bgyori merged 7 commits into
biopragmatics:mainfrom
nagutm:phagedive

Conversation

@nagutm

@nagutm nagutm commented Mar 9, 2025

Copy link
Copy Markdown
Collaborator

This PR curates a new prefix: phagedive.

PubMed: https://pubmed.ncbi.nlm.nih.gov/39373542/
Database: https://phagedive.dsmz.de/

It is a database of bacteriophages and archaeal viruses and provides details regarding their taxonomy, host strain, phage morphology, life cycle, origin and genomic data.

@nagutm
nagutm requested a review from bgyori March 9, 2025 21:34
@cthoyt

cthoyt commented Mar 10, 2025

Copy link
Copy Markdown
Member

we should consider the relation to DSMZ's other resource in the bioregistry "CellDive" https://bioregistry.io/registry/dsmz, which has a top-level prefix based on the organization itself. Maybe we subspace both under dsmz.celldive and dsmz.phagedive

@nagutm

nagutm commented Mar 20, 2025

Copy link
Copy Markdown
Collaborator Author

In addition to CellDive, there is also MediaDive and BacDive which also fall under the DSMZ umbrella. Since these other prefixes are not subspaced under dsmz, could we instead consider renaming the current dsmz prefix to celldive which is more specific and update the metadata to reflect this change?

Additionally, the cellosaurus mapping for the current dsmz prefix is also for CellDive, not DSMZ as a whole. The re3data, however, is for DSMZ as a whole and would probably need to be removed.

@cthoyt

cthoyt commented Mar 20, 2025

Copy link
Copy Markdown
Member

@nagutm that's a good point! I think there are a lot of references to dsmz because the cell line resource was their first big informatics one, but I agree that swapping this out for celldive would do good in the long run

Comment thread src/bioregistry/data/bioregistry.json Outdated
@codecov

codecov Bot commented Mar 29, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.17%. Comparing base (8950e70) to head (f34baf9).
Report is 393 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
+ Coverage   42.51%   47.17%   +4.66%     
==========================================
  Files         117      120       +3     
  Lines        8327     8721     +394     
  Branches     1963     1464     -499     
==========================================
+ Hits         3540     4114     +574     
+ Misses       4582     4367     -215     
- Partials      205      240      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bgyori
bgyori merged commit f981652 into biopragmatics:main Mar 29, 2025
@bgyori bgyori added Prefix New Used in combination with prefix, metaprefix, or collection for new entries labels Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Used in combination with prefix, metaprefix, or collection for new entries Prefix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants