Style: Rename unit test to match component name - #1185
Merged
pniedzielski merged 4 commits intoMar 30, 2026
Conversation
pniedzielski
marked this pull request as draft
March 6, 2026 22:47
Collaborator
Author
|
#1184 will conflict with this, since it modifies this file. Marking this as a draft since it will need a rebase. |
pniedzielski
force-pushed
the
style/initialconnectioncontex.t
branch
2 times, most recently
from
March 6, 2026 22:53
7bbd33c to
da4b303
Compare
pniedzielski
force-pushed
the
style/initialconnectioncontex.t
branch
2 times, most recently
from
March 20, 2026 16:22
0dadf7b to
d463aea
Compare
pniedzielski
marked this pull request as ready for review
March 20, 2026 16:23
pniedzielski
force-pushed
the
style/initialconnectioncontex.t
branch
4 times, most recently
from
March 24, 2026 13:44
889f036 to
676f4a5
Compare
chrisbeard
approved these changes
Mar 24, 2026
The `mqbnet_initialconnectioncontext` component’s unit test file was misnamed as `mqbnet_initialconnectioncontex`. This patch renames this file. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
Commit `f448eabdc95d96246ac2da0497ff7701c9252a28` cached the initial connection context by channel pointer rather than by the initial context shared pointer itself. The same change should have been made in the UT. However, since the UT for `InitialConnectionContext` was incorrectly named, our test harness did not pick it up, so we did not detect the build failure. This patch performs the same change as that commit on the `InitialConnectionContext` unit test. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
The `InitialConnectionContext` test used a `nullptr`, which fails in C++03 builds. This patch removes the `nullptr` usage. We have two options here: we can replace `nullptr` with a null pointer value, or we can pass a pointer to a real object in. Particularly here, the `AuthenticationContext` maintains a backpointer to `InitialConnectionContext` which the unit test is setting to `nullptr`. Given that we have a real `InitialConnectionContext` we can pass, and all the other values we use to construct `AuthenticationContext` are real, we choose here to pass real `InitialConnectionContext`. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
`bsl::allocate_shared` automatically forwards the allocator to the constructor of the object it is building correctly. Passing the allocator in addition causes a compiler error. This patch removes the extra allocator from a UT. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
pniedzielski
force-pushed
the
style/initialconnectioncontex.t
branch
from
March 25, 2026 06:13
676f4a5 to
4641e7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mqbnet_initialconnectioncontextcomponent’s unit test file was misnamed asmqbnet_initialconnectioncontex. This patch renames this file.