Skip to content

Style: Rename unit test to match component name #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pniedzielski merged 4 commits into from
Mar 30, 2026
Merged

Style: Rename unit test to match component name #1185

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e11063b
Style: Rename unit test to match component name
pniedzielski Mar 6, 2026
d82a34e
Fix[mqbnet]: Remove `InitialContextContext` pointer from UT cb
pniedzielski Mar 20, 2026
07db7d0
Fix[mqbnet]: Remove `nullptr` for C++03 compatibility
pniedzielski Mar 20, 2026
4641e7f
Fix[mqbnet]: Remove extra `alloc` argument from UT
pniedzielski Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions ...bnet/mqbnet_initialconnectioncontex.t.cpp → ...net/mqbnet_initialconnectioncontext.t.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ void complete(const bsl::shared_ptr<int>& check,
int status,
const bsl::string& errorDescription,
const bsl::shared_ptr<mqbnet::Session>& session,
const bsl::shared_ptr<bmqio::Channel>& channel,
const mqbnet::InitialConnectionContext* initialConnectionContext)
const bsl::shared_ptr<bmqio::Channel>& channel)
{
BSLS_ASSERT_SAFE(check);

Expand All @@ -55,7 +54,6 @@ void complete(const bsl::shared_ptr<int>& check,
(void)errorDescription;
(void)session;
(void)channel;
(void)initialConnectionContext;
}

// Mock authenticator
Expand Down Expand Up @@ -128,14 +126,12 @@ static void test1_initialConnectionContext()

bsl::shared_ptr<int> check = bsl::allocate_shared<int>(alloc, 0);
mqbnet::InitialConnectionContext::InitialConnectionCompleteCb completeCb =
bdlf::BindUtil::bind(
&complete,
check,
bdlf::PlaceHolders::_1, // status
bdlf::PlaceHolders::_2, // errorDescription
bdlf::PlaceHolders::_3, // session
bdlf::PlaceHolders::_4, // channel
bdlf::PlaceHolders::_5 // initialConnectionContext
bdlf::BindUtil::bind(&complete,
check,
bdlf::PlaceHolders::_1, // status
bdlf::PlaceHolders::_2, // errorDescription
bdlf::PlaceHolders::_3, // session
bdlf::PlaceHolders::_4 // channel
);

bmqtst::TestHelper::printTestName("test1_basicConstruction");
Expand Down Expand Up @@ -175,12 +171,11 @@ static void test1_initialConnectionContext()
bsl::shared_ptr<mqbnet::AuthenticationContext> authnCtx =
bsl::allocate_shared<mqbnet::AuthenticationContext>(
alloc,
nullptr, // initialConnectionContext
&obj,
"testMechanism",
authnMsg,
bmqp::EncodingType::e_BER,
mqbnet::AuthenticationState::e_AUTHENTICATING,
alloc);
mqbnet::AuthenticationState::e_AUTHENTICATING);
obj.setAuthenticationContext(authnCtx);
BMQTST_ASSERT_EQ(authnCtx, obj.authenticationContext());
}
Expand Down
Loading