Refactor[bmq,mqb]: un-template request managers - #1562
Open
678098 wants to merge 1 commit into
Open
Conversation
678098
force-pushed
the
260623_untemplate_request_managers
branch
from
June 23, 2026 20:26
9da28fa to
302595f
Compare
678098
force-pushed
the
260623_untemplate_request_managers
branch
2 times, most recently
from
June 23, 2026 20:42
065dcab to
65ce7cc
Compare
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
678098
force-pushed
the
260623_untemplate_request_managers
branch
from
July 10, 2026 19:34
65ce7cc to
436d920
Compare
pniedzielski
approved these changes
Jul 27, 2026
Collaborator
|
This is a Good Change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bmqp::RequestManagerandmqbnet::MultiRequestManageralways have the same template argsREQUEST == RESPONSE == bmqp_ctrlmsg::ControlMessage. The only reason why it is a template is for not including#include <bmqp_ctrlmsg_messages.h>. However, we still include this header. Due to this, template args are not doing anything other than making the code more complex.#include <bmqp_ctrlmsg_messages.h>in both class sources, but this should be done not with templates, but with forward declarations and code organization. This PR is a preparation for this.RequestManagerType::RequestSp->RequestSp