You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@g-plane I have fixed formatting errors and also updated submodule versions to make sure cargo test passes. Could you please approve the workflow if you have time?
@g-planeWould you like to review this PR first? It looks like baseline-browsers-mapping upstream doesn't currently have an active reviewer, and I feel it could take a few more weeks to wait for the author's response. We could move forward with this implementation now and incorporate their feedback in a later release if needed. Whether they accept our contribution upstream doesn't affect the implementation of baseline queries here.
It looks like they have agreed with our suggestions, we can wait them to publish new version and merge later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #40.
vendor/baseline-browser-mapping