Change CheckDecorator type#94
Open
PythonCoderAS wants to merge 1 commit intobryanforbes:masterfrom
PythonCoderAS:patch-2
Open
Change CheckDecorator type#94PythonCoderAS wants to merge 1 commit intobryanforbes:masterfrom PythonCoderAS:patch-2
PythonCoderAS wants to merge 1 commit intobryanforbes:masterfrom
PythonCoderAS:patch-2
Conversation
The decorator returned by `check()` has an attribute, `predicate`, that is relied upon by `check_any()`. Therefore, a check decorator cannot just be anything that returns a function but must include this attribute as well. `check_any()` also relies on this attribute, which is not present in `_CheckPredicate`.
bryanforbes
reviewed
Jul 6, 2021
| @type_check_only | ||
| class _CheckDecorator(Protocol): | ||
| class _CheckDecorator: | ||
| predicate: _CheckPredicate[_CT] |
Owner
There was a problem hiding this comment.
To keep _CheckDecorator so it's not generic, _CT needs to be chaned to Any here
Contributor
Author
There was a problem hiding this comment.
Would it be reasonable to set discord.ext.commands.Context, since that will always be a Context instance?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decorator returned by
check()has an attribute,predicate, that is relied upon bycheck_any(). Therefore, a check decorator cannot just be anything that returns a function but must include this attribute as well.check_any()also relies on this attribute, which is not present in_CheckPredicate.