Skip to content

Change CheckDecorator type #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PythonCoderAS wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change CheckDecorator type #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions discord-stubs/ext/commands/core.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ class _CheckPredicate(Protocol[_T_contra]):
def __call__(self, __ctx: _T_contra) -> Union[bool, Coroutine[Any, Any, bool]]: ...

@type_check_only
class _CheckDecorator(Protocol):
class _CheckDecorator:
predicate: _CheckPredicate[_CT]
Copy link
Copy Markdown
Owner

@bryanforbes bryanforbes Jul 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep _CheckDecorator so it's not generic, _CT needs to be chaned to Any here

Copy link
Copy Markdown
Contributor Author

@PythonCoderAS PythonCoderAS Jul 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be reasonable to set discord.ext.commands.Context, since that will always be a Context instance?

def __call__(self, __func: _F) -> _F: ...

@type_check_only
Expand Down Expand Up @@ -275,7 +276,7 @@ def group(
case_insensitive: bool = ...,
) -> Callable[[_CoroType], Group[Any]]: ...
def check(predicate: _CheckPredicate[_CT]) -> _CheckDecorator: ...
def check_any(*checks: _CheckPredicate[_CT]) -> _CheckDecorator: ...
def check_any(*checks: _CheckDecorator) -> _CheckDecorator: ...
def has_role(item: Union[int, str]) -> _CheckDecorator: ...
def has_any_role(*items: Union[int, str]) -> _CheckDecorator: ...
def bot_has_role(item: Union[int, str]) -> _CheckDecorator: ...
Expand Down