Serbian Latin fixes - #53
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated Serbian translation strings in one file: standardized BIP39/passphrase wording, replaced several UI terms (e.g., "QR code" → "QR kôd", "App-based 2FA" → "2FA putem aplikacije"), adjusted POS/Lightning/payment/status phrasing and grammatical forms. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
Translator/translations/serbian.json (2)
935-935: Consider restoring a full sentence form for tagline tone.Line 935 drops the explicit subject/verb (“Bezbedan, privatan...”). If this string is shown as a standalone sentence, “On je...” / “To je...” style reads more complete.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Translator/translations/serbian.json` at line 935, The tagline translation currently omits an explicit subject; update the JSON entry for the key "It is secure, private, censorship-resistant and free." in translations/serbian.json so it reads as a full sentence (e.g. change the value to "On je bezbedan, privatan, otporan na cenzuru i besplatan." or "To je bezbedan, privatan, otporan na cenzuru i besplatan."); locate the string by its exact English key and replace the value while keeping JSON formatting intact.
1857-1857: Prefer a more natural Serbian noun phrase for “representation”.Line 1857 uses “reprezentacija,” which sounds awkward in UI copy. A native phrasing is clearer.
Suggested wording
- "The QR code representation of the invitation link": "QR kôd reprezentacija linka za pozivnicu", + "The QR code representation of the invitation link": "QR kôd prikaz linka za pozivnicu",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Translator/translations/serbian.json` at line 1857, The translation for the key "The QR code representation of the invitation link" uses the awkward noun "reprezentacija"; update its value to a more natural Serbian phrasing such as using "prikaz" or a short descriptive phrase—e.g. replace "QR kôd reprezentacija linka za pozivnicu" with "QR kôd koji prikazuje link za pozivnicu" or "QR kôd prikaza linka za pozivnicu" so the UI copy reads naturally; change the value for that exact key in the JSON entry.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Translator/translations/serbian.json`:
- Around line 396-397: The translations for the keys "Confirm passphrase" and
"Confirm password" are written as imperatives ("Potvrdite ...") instead of
field-labels and should be changed to label wording to match other entries
(e.g., the existing "Potvrda ..." at Line 1202). Update the value for "Confirm
passphrase" from "Potvrdite dodatnu lozinku." to a label form like "Potvrda
dodatne lozinke" and update "Confirm password" from "Potvrdite lozinku" to
"Potvrda lozinke" so the translations are consistent with field-label style.
- Line 1517: The translation for the key "Scan wallet QR with camera" has
incorrect object order implying the wallet's camera; update the Serbian value so
it reads "Skenirajte QR kôd novčanika kamerom" (or equivalent natural Serbian)
to convey scanning the wallet's QR code with the device camera; locate the
string by the key "Scan wallet QR with camera" in the Serbian translations and
replace the current value "Skenirajte QR kôd kamerom novčanika" with the
corrected wording.
---
Nitpick comments:
In `@Translator/translations/serbian.json`:
- Line 935: The tagline translation currently omits an explicit subject; update
the JSON entry for the key "It is secure, private, censorship-resistant and
free." in translations/serbian.json so it reads as a full sentence (e.g. change
the value to "On je bezbedan, privatan, otporan na cenzuru i besplatan." or "To
je bezbedan, privatan, otporan na cenzuru i besplatan."); locate the string by
its exact English key and replace the value while keeping JSON formatting
intact.
- Line 1857: The translation for the key "The QR code representation of the
invitation link" uses the awkward noun "reprezentacija"; update its value to a
more natural Serbian phrasing such as using "prikaz" or a short descriptive
phrase—e.g. replace "QR kôd reprezentacija linka za pozivnicu" with "QR kôd koji
prikazuje link za pozivnicu" or "QR kôd prikaza linka za pozivnicu" so the UI
copy reads naturally; change the value for that exact key in the JSON entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 17ae20a1-687b-4294-91a6-e5fa55e38723
📒 Files selected for processing (1)
Translator/translations/serbian.json
Comment on lines
+396
to
+397
| "Confirm passphrase": "Potvrdite dodatnu lozinku.", | ||
| "Confirm password": "Potvrdite lozinku", |
Contributor
There was a problem hiding this comment.
Use field-label wording instead of imperative in confirmation labels.
Line 396 and Line 397 read like button commands (“Potvrdite ...”), while these keys are typically field labels. This can feel inconsistent next to Line 1202 (“Potvrda ...”).
Suggested wording
- "Confirm passphrase": "Potvrdite dodatnu lozinku.",
- "Confirm password": "Potvrdite lozinku",
+ "Confirm passphrase": "Potvrda dodatne lozinke",
+ "Confirm password": "Potvrda lozinke",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "Confirm passphrase": "Potvrdite dodatnu lozinku.", | |
| "Confirm password": "Potvrdite lozinku", | |
| "Confirm passphrase": "Potvrda dodatne lozinke", | |
| "Confirm password": "Potvrda lozinke", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Translator/translations/serbian.json` around lines 396 - 397, The
translations for the keys "Confirm passphrase" and "Confirm password" are
written as imperatives ("Potvrdite ...") instead of field-labels and should be
changed to label wording to match other entries (e.g., the existing "Potvrda
..." at Line 1202). Update the value for "Confirm passphrase" from "Potvrdite
dodatnu lozinku." to a label form like "Potvrda dodatne lozinke" and update
"Confirm password" from "Potvrdite lozinku" to "Potvrda lozinke" so the
translations are consistent with field-label style.
added 2 commits
April 28, 2026 17:04
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (1)
Translator/translations/serbian.json (1)
396-397:⚠️ Potential issue | 🟡 MinorUse field-label phrasing for confirmation labels (still imperative).
These two values still read like commands, not field labels, and remain inconsistent with nearby label-style entries (e.g., confirmation noun forms).
Suggested fix
- "Confirm passphrase": "Potvrdite dodatnu lozinku.", - "Confirm password": "Potvrdite lozinku", + "Confirm passphrase": "Potvrda dodatne lozinke", + "Confirm password": "Potvrda lozinke",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Translator/translations/serbian.json` around lines 396 - 397, The JSON entries for the keys "Confirm passphrase" and "Confirm password" are phrased as commands; change them to field-label noun forms to match surrounding labels — replace "Potvrdite dodatnu lozinku." with a label-style translation such as "Potvrda dodatne lozinke" and replace "Potvrdite lozinku" with "Potvrda lozinke" in the Translator/translations/serbian.json to keep consistency with neighboring confirmation noun entries.
🧹 Nitpick comments (1)
Translator/translations/serbian.json (1)
975-975: Consider consistent Serbian terminology for mixed English nouns.
"network-a"and"payment"are still mixed-language in otherwise localized strings. Not blocking, but consistency would improve UX polish.Possible wording cleanup
- "Lightning network settings": "Podešavanja Lightning network-a", + "Lightning network settings": "Podešavanja Lightning mreže", - "Unify on-chain and lightning payment URL/QR code": "Ujedini on-chain i lightning payment URL/QR kôd", + "Unify on-chain and lightning payment URL/QR code": "Ujedini on-chain i lightning URL/QR kôd za plaćanje",Also applies to: 2064-2064
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Translator/translations/serbian.json` at line 975, The translation for the key "Lightning network settings" uses mixed-language phrasing ("Podešavanja Lightning network-a"); update it to a consistent Serbian form (e.g., "Podešavanja Lightning mreže" or a fully localized variant like "Podešavanja Lightning platnog sistema") and apply the same consistency to other occurrences (notably the strings around the other mention at the key near line 2064) so all "network"/"payment" usages follow the chosen Serbian terminology; edit the value for the "Lightning network settings" key and harmonize equivalent keys/values elsewhere in the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Translator/translations/serbian.json`:
- Line 1325: The translation for the key "Plugin Updates" uses singular
"Ažuriranja dodatka"; update the value for the "Plugin Updates" key to the
correct plural form (e.g., "Ažuriranja dodataka") so the translation matches the
plural English key and grammar.
- Line 1198: The translation for the label "Pairing Permission" is currently an
imperative ("Odobri zahtev za uparivanje"); replace it with a noun phrase to
match the key (e.g., "Dozvola za uparivanje" or "Dozvola za povezivanje") so the
value reflects a permission/entity rather than an action.
- Line 876: The translation for the JSON key "Input the key string manually"
currently hardcodes “prošireni javni ključ”; update the value to a generic
phrasing that preserves the original "key string" meaning (for example, "Ručno
unesite ključ" or "Ručno unesite key string") so it will work for different key
formats; change the string value for the "Input the key string manually" entry
accordingly.
---
Duplicate comments:
In `@Translator/translations/serbian.json`:
- Around line 396-397: The JSON entries for the keys "Confirm passphrase" and
"Confirm password" are phrased as commands; change them to field-label noun
forms to match surrounding labels — replace "Potvrdite dodatnu lozinku." with a
label-style translation such as "Potvrda dodatne lozinke" and replace "Potvrdite
lozinku" with "Potvrda lozinke" in the Translator/translations/serbian.json to
keep consistency with neighboring confirmation noun entries.
---
Nitpick comments:
In `@Translator/translations/serbian.json`:
- Line 975: The translation for the key "Lightning network settings" uses
mixed-language phrasing ("Podešavanja Lightning network-a"); update it to a
consistent Serbian form (e.g., "Podešavanja Lightning mreže" or a fully
localized variant like "Podešavanja Lightning platnog sistema") and apply the
same consistency to other occurrences (notably the strings around the other
mention at the key near line 2064) so all "network"/"payment" usages follow the
chosen Serbian terminology; edit the value for the "Lightning network settings"
key and harmonize equivalent keys/values elsewhere in the file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9adf7d92-956f-4fe7-9a46-bd4b8e2db371
📒 Files selected for processing (1)
Translator/translations/serbian.json
| "Increase the security of your instance by disabling the ability to change the SSH settings in this BTCPay Server instance's user interface.": "Povećajte bezbednost vaše instance onemogućavanjem mogućnosti menjanja SSH podešavanja u korisničkom interfejsu ove BTCPay Server instance.", | ||
| "Index": "Indeks", | ||
| "Input the key string manually": "Unesite ključ string ručno", | ||
| "Input the key string manually": "Ručno unesite prošireni javni ključ", |
Contributor
There was a problem hiding this comment.
Avoid narrowing “key string” to only “extended public key.”
The source key is generic (“key string”), but the translation hardcodes it to “prošireni javni ključ,” which can be semantically too narrow in UI flows that accept different key formats.
Suggested fix
- "Input the key string manually": "Ručno unesite prošireni javni ključ",
+ "Input the key string manually": "Ručno unesite niz ključa",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Translator/translations/serbian.json` at line 876, The translation for the
JSON key "Input the key string manually" currently hardcodes “prošireni javni
ključ”; update the value to a generic phrasing that preserves the original "key
string" meaning (for example, "Ručno unesite ključ" or "Ručno unesite key
string") so it will work for different key formats; change the string value for
the "Input the key string manually" entry accordingly.
| "Pair to": "Upariti sa", | ||
| "Pair To Store": "Uparivanje sa prodavnicom", | ||
| "Pairing Permission": "Dozvola za uparivanje", | ||
| "Pairing Permission": "Odobri zahtev za uparivanje", |
Contributor
There was a problem hiding this comment.
Translate “Pairing Permission” as a noun phrase, not an action.
Current value is imperative (“Odobri…”), while the key is a label/entity (“Permission”).
Suggested fix
- "Pairing Permission": "Odobri zahtev za uparivanje",
+ "Pairing Permission": "Dozvola za uparivanje",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "Pairing Permission": "Odobri zahtev za uparivanje", | |
| "Pairing Permission": "Dozvola za uparivanje", |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Translator/translations/serbian.json` at line 1198, The translation for the
label "Pairing Permission" is currently an imperative ("Odobri zahtev za
uparivanje"); replace it with a noun phrase to match the key (e.g., "Dozvola za
uparivanje" or "Dozvola za povezivanje") so the value reflects a
permission/entity rather than an action.
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Translator/translations/serbian.json (1)
400-402: Consider keeping imperative tone consistent (“Poveži” vs “Povežite”).Line [400]–Line [402] use informal singular imperative, while many adjacent actions use formal/plural. Optional, but harmonizing tone improves UI consistency.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Translator/translations/serbian.json` around lines 400 - 402, The translations for the keys "Connect an existing wallet", "Connect BTCPay Server to your Shopify checkout experience to accept Bitcoin.", and "Connect hardware wallet" use informal singular imperative ("Poveži"); update them to the formal/plural imperative to match surrounding entries—e.g., change to "Povežite postojeći novčanik", "Povežite BTCPay Server sa vašim Shopify checkout iskustvom da biste prihvatali Bitcoin.", and "Povežite hardverski novčanik"—so the UI tone is consistent across the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Translator/translations/serbian.json`:
- Around line 400-402: The translations for the keys "Connect an existing
wallet", "Connect BTCPay Server to your Shopify checkout experience to accept
Bitcoin.", and "Connect hardware wallet" use informal singular imperative
("Poveži"); update them to the formal/plural imperative to match surrounding
entries—e.g., change to "Povežite postojeći novčanik", "Povežite BTCPay Server
sa vašim Shopify checkout iskustvom da biste prihvatali Bitcoin.", and "Povežite
hardverski novčanik"—so the UI tone is consistent across the file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c1e4f735-c553-466d-8d3a-737751e2e79f
📒 Files selected for processing (1)
Translator/translations/serbian.json
Collaborator
|
@Sanja22B is this PR good to go ? |
Collaborator
Author
|
Hi @Abhijay007 , yes, I think it can be merged now. |
Abhijay007
approved these changes
May 1, 2026
Abhijay007
left a comment
Abhijay007
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks @Sanja22B for another great PR
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes to the Serbian Latin translation.