Skip to content

26-06-03_Update Translation_de_DE - #73

Merged
rockstardev merged 2 commits into
btcpayserver:mainfrom
bsn21m:main
Jun 9, 2026
Merged

26-06-03_Update Translation_de_DE#73
rockstardev merged 2 commits into
btcpayserver:mainfrom
bsn21m:main

Conversation

@bsn21m

@bsn21m bsn21m commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b73f4ed9-ba75-4f7b-ab4b-1a0aa62571a0

📥 Commits

Reviewing files that changed from the base of the PR and between 202b171 and 8ae5f51.

📒 Files selected for processing (2)
  • manifest.json
  • translations/german.json

📝 Walkthrough

Walkthrough

German translation strings and metadata are updated in a single cohort. The manifest metadata for the German (de-DE) language entry is refreshed, and six translation values are corrected for terminology consistency and phrasing accuracy across UI labels and messages.

Changes

German Translation Corrections

Layer / File(s) Summary
German translation corrections and metadata
manifest.json, translations/german.json
Six German UI text translations are corrected for terminology ("Standardtarif", "Tarif" wording, charging prompt phrasing, label text), and the German entry metadata (SHA and timestamp) in the manifest is updated to reflect the new content.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 Hopping through translations with care,
German words polished, refined with flair—
"Standardtarif" now flows just right,
Manifest glows with timestamp's light! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided, but the title and file changes are self-explanatory for a routine translation update. Consider adding a brief description explaining the translation corrections made, even if minimal (e.g., listing the corrected UI text labels).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating German language translations with a specific date reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Abhijay007

Copy link
Copy Markdown
Collaborator

@bsn21m can you also please update the strings to latest?

@bsn21m

bsn21m commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the note. From our side everything currently looks up to date, and german.json appears to be in sync. Could you please clarify what you mean by “update the strings to latest” or point out which strings you believe are still missing or need to be updated?

@rockstardev

Copy link
Copy Markdown
Member

@bsn21m a bunch of new strings have been added between when german.json was created and now that BTCPay 2.4 is being released.

You've done a good job on this, so I'll merge it. Please keep an eye out for any new keys that get added - I'll do that across all translations.

@rockstardev
rockstardev merged commit a8c4733 into btcpayserver:main Jun 9, 2026
2 checks passed
@rockstardev

Copy link
Copy Markdown
Member

OK, here is the PR with all new keys and some QOL updates: #74

@bsn21m if you are bsn-21m on https://chat.btcpayserver.org let me know - I would DM you to talk about maintaining German translations. Or we just give it over to @ndeet 😉

@bsn21m

bsn21m commented Jun 10, 2026 via email

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants