Skip to content

Make pause key actually pause#431

Merged
caiiiycuk merged 5 commits into
caiiiycuk:8.xxfrom
donno2048:8.xx
May 11, 2026
Merged

Make pause key actually pause#431
caiiiycuk merged 5 commits into
caiiiycuk:8.xxfrom
donno2048:8.xx

Conversation

@donno2048

Copy link
Copy Markdown
Contributor

fixes #363

Comment thread src/window/dos/controls/keyboard.ts Outdated
@donno2048

Copy link
Copy Markdown
Contributor Author

@caiiiycuk can you review again?

@caiiiycuk

Copy link
Copy Markdown
Owner

I think you forget to commit dosSlice file

@donno2048

donno2048 commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

I think you forget to commit dosSlice file

No need to commit any change, I'm relying on this

js-dos/src/store/dos.ts

Lines 308 to 310 in 41216f4

paused: (s, a: { payload: boolean }) => {
s.paused = a.payload;
},

@caiiiycuk

Copy link
Copy Markdown
Owner

@donno2048 please fix the build to pass ci pipeline

@donno2048

Copy link
Copy Markdown
Contributor Author

@caiiiycuk can you approve workflow run?

@donno2048

donno2048 commented May 10, 2026

Copy link
Copy Markdown
Contributor Author

@caiiiycuk can you review?

Comment thread src/window/dos/controls/keyboard.ts Outdated
@donno2048

Copy link
Copy Markdown
Contributor Author

@caiiiycuk fixed

@caiiiycuk
caiiiycuk merged commit 5cb8361 into caiiiycuk:8.xx May 11, 2026
1 check passed
@caiiiycuk

Copy link
Copy Markdown
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pause key doesn't work as expected

2 participants