Skip to content

Make pause key actually pause #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caiiiycuk merged 5 commits into from
May 11, 2026
Merged

Make pause key actually pause #431

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad4df9d
make pause key actually pause
donno2048 May 7, 2026
faf01e9
make pause an argument
donno2048 May 7, 2026
65e53ba
pass paused to keyboard
donno2048 May 7, 2026
a7aa420
lint
donno2048 May 8, 2026
3423bfd
let pause logic handle pause
donno2048 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/window/dos/controls/keyboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
import { CommandInterface } from "emulators";
import { domToKeyCode } from "./keys";
import { domToKeyCode, KBD_pause } from "./keys";
import { Dispatch } from "@reduxjs/toolkit";
import { sendQuickLoadEvent, sendQuickSaveEvent } from "../../../player-api";
import { uiSlice } from "../../../store/ui";
import { dosSlice } from "../../../store/dos";

let paused = false;
Comment thread
donno2048 marked this conversation as resolved.
Outdated

export function keyboard(el: HTMLElement, ci: CommandInterface, handleQuickSaves: boolean, dispatch: Dispatch) {
const pressedKeys = new Set<number>();

Expand Down Expand Up @@ -30,10 +34,18 @@ export function keyboard(el: HTMLElement, ci: CommandInterface, handleQuickSaves
}

const keyCode = domToKeyCode(e.keyCode, e.location);
ci.sendKeyEvent(keyCode, true);
pressedKeys.add(keyCode);
e.stopPropagation();
e.preventDefault();
if (keyCode === KBD_pause) {
paused = !paused;
dispatch(dosSlice.actions.paused(paused));
if (paused) ci.pause();
else ci.resume();
}
else {
ci.sendKeyEvent(keyCode, true);
pressedKeys.add(keyCode);
e.stopPropagation();
e.preventDefault();
}
}

function onKeyUp(e: KeyboardEvent) {
Expand Down