Skip to content

new-page: ceph/support [WD-35847] - #2512

Merged
Stefan3002 merged 1 commit into
canonical:mainfrom
Stefan3002:ceph-support-page
May 7, 2026
Merged

new-page: ceph/support [WD-35847]#2512
Stefan3002 merged 1 commit into
canonical:mainfrom
Stefan3002:ceph-support-page

Conversation

@Stefan3002

@Stefan3002 Stefan3002 commented May 6, 2026

Copy link
Copy Markdown
Contributor

Done

  • copy-doc
  • Figma
  • Assets
  • The images at the end of the copy doc are wrong and we should use the ones in the Figma design (confirmed with designer)
  • There are two links that will have to be changed before merging. The link will be available once this is done

QA

  • Open the DEMO
  • Navigate to /ceph/support
  • Alternatively, check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • Make sure the design follows the Figma design
  • Make sure the page follows the copy-doc
  • Also please check that the buttons open the contact modal correctly

Issue / Card

Fixes #WD-35847

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

@webteam-app

Copy link
Copy Markdown

@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.96%. Comparing base (1de2fe9) to head (18ece06).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2512   +/-   ##
=======================================
  Coverage   78.96%   78.96%           
=======================================
  Files          16       16           
  Lines        1930     1930           
=======================================
  Hits         1524     1524           
  Misses        406      406           
Flag Coverage Δ
python 78.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattea-turic

mattea-turic commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Looks good, thanks for the quick updates @Stefan3002 !

Only two small comments:

For "Cost-effective Ceph support":

  • Could you apply paragraph styling to the entirety of the body, as right now the paragraph "Transparent pricing meets..." has h5 styling
  • Pls apply image highlight class (p-image-container is-highlighted) to the containers in this section
  • And could the reg. section wrapping be removed? As paired with the "deep" section, it's too much padding :')
Screenshot 2026-05-06 at 5 29 06 PM

Approving with the above changes :)

@Stefan3002

Copy link
Copy Markdown
Contributor Author

For the fellow engineer: can we remove the padding of the equal-height macro at the end of the page? It's 64 px

Comment thread templates/ceph/support.html Outdated
{% from "_macros/vf_equal-heights.jinja" import vf_equal_heights %}
{% from "_macros/vf_tiered-list.jinja" import vf_tiered_list %}
{% from "_macros/vf_data-spotlight.jinja" import vf_data_spotlight %}
{% block title %}Ceph support | Ceph{% endblock %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% block title %}Ceph support | Ceph{% endblock %}
{% block title %}Canonical Ceph support{% endblock %}

{% from "_macros/vf_tiered-list.jinja" import vf_tiered_list %}
{% from "_macros/vf_data-spotlight.jinja" import vf_data_spotlight %}
{% block title %}Ceph support | Ceph{% endblock %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% block body_class %}is-paper{% endblock %}

Comment thread templates/ceph/support.html Outdated

</section>

{{ load_form("/ceph") | safe }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ load_form("/ceph") | safe }}
{{ load_form("/ceph") | safe }}
<script defer src="{{ versioned_static('js/modals.js') }}"></script>
<script src="{{ versioned_static('js/in-page-navigation.js') }}"></script>

Comment thread templates/ceph/support.html Outdated

<section class="p-section--deep">

{% call(slot) vf_equal_heights(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the formatting for this block of code.

{% from "_macros/vf_data-spotlight.jinja" import vf_data_spotlight %}
{% block title %}Ceph support | Ceph{% endblock %}

{% block meta_description %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs formatting fix. Refer to the template for /ceph

https://docs.google.com/document/d/1HFtvu3abhwL5ulgWZzZGpElJNqMVAW3qeeEs7APvZRA/edit?tab=t.jijjhiya0no5#heading=h.n7un9v779syf
{% endblock meta_copydoc %}

{% block content %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting

Comment thread templates/ceph/support.html Outdated
{% endblock meta_description %}

{% block meta_copydoc %}
https://docs.google.com/document/d/1HFtvu3abhwL5ulgWZzZGpElJNqMVAW3qeeEs7APvZRA/edit?tab=t.jijjhiya0no5#heading=h.n7un9v779syf

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://docs.google.com/document/d/1HFtvu3abhwL5ulgWZzZGpElJNqMVAW3qeeEs7APvZRA/edit?tab=t.jijjhiya0no5#heading=h.n7un9v779syf
https://docs.google.com/document/d/1HFtvu3abhwL5ulgWZzZGpElJNqMVAW3qeeEs7APvZRA/edit?tab=t.jijjhiya0no5

Comment thread templates/ceph/support.html Outdated
{%- endif -%}
{%- if slot == 'cta' -%}
<a href="#get-in-touch" class="p-button--positive" aria-label="contact-modal">Get in touch</a>
<a href="https://canonical.com/case-study/esa" class="p-button" aria-label="case study">Access the case study</a>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://canonical.com/case-study/esa" class="p-button" aria-label="case study">Access the case study</a>
<a href="/case-study/esa" class="p-button" aria-label="case study">Access the case study</a>

Comment thread templates/ceph/support.html Outdated
<p>
From the initial design and hardware selection, to ongoing software support and management, Canonical’s offerings cover all types of Ceph deployments on Ubuntu. Available 24/7/365, by telephone and ticket.
</p>
<p><a href="https://canonical.com/ceph">Discover Canonical Ceph &rsaquo;</a></p>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p><a href="https://canonical.com/ceph">Discover Canonical Ceph &rsaquo;</a></p>
<p><a href="/ceph">Discover Canonical Ceph &rsaquo;</a></p>

@Skazitron Skazitron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this @Stefan3002! Just address these comments and you should be good to go!

@Stefan3002
Stefan3002 force-pushed the ceph-support-page branch from 4277330 to 4324329 Compare May 7, 2026 11:22
@Stefan3002
Stefan3002 requested a review from Skazitron May 7, 2026 11:22
@Stefan3002
Stefan3002 force-pushed the ceph-support-page branch from 4324329 to 16b0938 Compare May 7, 2026 11:53
@eliman11

eliman11 commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Thanks @Stefan3002 apologies for the delay as I'm on sprint! Comments -

  • "Transparent pricing meets enterprise-grade Ceph support..." shouldn't be bolded
  • Could we move the text around so that "24/7/365" sits on the first line and "Coverage.." sits on the second? I added the changes in suggesting mode on the copy doc as well
Screenshot 2026-05-07 at 10 27 08
  • Remove alt text for images under "Cost-effective Ceph support"

These are minor so will +1 with the changes

@Skazitron Skazitron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Stefan3002
Stefan3002 force-pushed the ceph-support-page branch from cac0c5f to 18ece06 Compare May 7, 2026 13:28
@Stefan3002
Stefan3002 merged commit 23be6c5 into canonical:main May 7, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants