new-page: ceph/support [WD-35847] - #2512
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2512 +/- ##
=======================================
Coverage 78.96% 78.96%
=======================================
Files 16 16
Lines 1930 1930
=======================================
Hits 1524 1524
Misses 406 406
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks good, thanks for the quick updates @Stefan3002 ! Only two small comments: For "Cost-effective Ceph support":
Approving with the above changes :) |
|
For the fellow engineer: can we remove the padding of the equal-height macro at the end of the page? It's 64 px |
| {% from "_macros/vf_equal-heights.jinja" import vf_equal_heights %} | ||
| {% from "_macros/vf_tiered-list.jinja" import vf_tiered_list %} | ||
| {% from "_macros/vf_data-spotlight.jinja" import vf_data_spotlight %} | ||
| {% block title %}Ceph support | Ceph{% endblock %} |
There was a problem hiding this comment.
| {% block title %}Ceph support | Ceph{% endblock %} | |
| {% block title %}Canonical Ceph support{% endblock %} |
| {% from "_macros/vf_tiered-list.jinja" import vf_tiered_list %} | ||
| {% from "_macros/vf_data-spotlight.jinja" import vf_data_spotlight %} | ||
| {% block title %}Ceph support | Ceph{% endblock %} | ||
|
|
There was a problem hiding this comment.
| {% block body_class %}is-paper{% endblock %} |
|
|
||
| </section> | ||
|
|
||
| {{ load_form("/ceph") | safe }} |
There was a problem hiding this comment.
| {{ load_form("/ceph") | safe }} | |
| {{ load_form("/ceph") | safe }} | |
| <script defer src="{{ versioned_static('js/modals.js') }}"></script> | |
| <script src="{{ versioned_static('js/in-page-navigation.js') }}"></script> |
|
|
||
| <section class="p-section--deep"> | ||
|
|
||
| {% call(slot) vf_equal_heights( |
There was a problem hiding this comment.
Please fix the formatting for this block of code.
| {% from "_macros/vf_data-spotlight.jinja" import vf_data_spotlight %} | ||
| {% block title %}Ceph support | Ceph{% endblock %} | ||
|
|
||
| {% block meta_description %} |
There was a problem hiding this comment.
Needs formatting fix. Refer to the template for /ceph
| https://docs.google.com/document/d/1HFtvu3abhwL5ulgWZzZGpElJNqMVAW3qeeEs7APvZRA/edit?tab=t.jijjhiya0no5#heading=h.n7un9v779syf | ||
| {% endblock meta_copydoc %} | ||
|
|
||
| {% block content %} |
| {% endblock meta_description %} | ||
|
|
||
| {% block meta_copydoc %} | ||
| https://docs.google.com/document/d/1HFtvu3abhwL5ulgWZzZGpElJNqMVAW3qeeEs7APvZRA/edit?tab=t.jijjhiya0no5#heading=h.n7un9v779syf |
There was a problem hiding this comment.
| https://docs.google.com/document/d/1HFtvu3abhwL5ulgWZzZGpElJNqMVAW3qeeEs7APvZRA/edit?tab=t.jijjhiya0no5#heading=h.n7un9v779syf | |
| https://docs.google.com/document/d/1HFtvu3abhwL5ulgWZzZGpElJNqMVAW3qeeEs7APvZRA/edit?tab=t.jijjhiya0no5 |
| {%- endif -%} | ||
| {%- if slot == 'cta' -%} | ||
| <a href="#get-in-touch" class="p-button--positive" aria-label="contact-modal">Get in touch</a> | ||
| <a href="https://canonical.com/case-study/esa" class="p-button" aria-label="case study">Access the case study</a> |
There was a problem hiding this comment.
| <a href="https://canonical.com/case-study/esa" class="p-button" aria-label="case study">Access the case study</a> | |
| <a href="/case-study/esa" class="p-button" aria-label="case study">Access the case study</a> |
| <p> | ||
| From the initial design and hardware selection, to ongoing software support and management, Canonical’s offerings cover all types of Ceph deployments on Ubuntu. Available 24/7/365, by telephone and ticket. | ||
| </p> | ||
| <p><a href="https://canonical.com/ceph">Discover Canonical Ceph ›</a></p> |
There was a problem hiding this comment.
| <p><a href="https://canonical.com/ceph">Discover Canonical Ceph ›</a></p> | |
| <p><a href="/ceph">Discover Canonical Ceph ›</a></p> |
Skazitron
left a comment
There was a problem hiding this comment.
Good job on this @Stefan3002! Just address these comments and you should be good to go!
4277330 to
4324329
Compare
4324329 to
16b0938
Compare
|
Thanks @Stefan3002 apologies for the delay as I'm on sprint! Comments -
These are minor so will +1 with the changes |
6067c74 to
cac0c5f
Compare
cac0c5f to
18ece06
Compare


Done
QA
./run serveordotrunIssue / Card
Fixes #WD-35847
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines