refactor: reuse single discourse cache across API instances - #2831
Merged
Conversation
Demo
Jenkins 
demos.haus
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Flask app’s Discourse integrations to reduce duplicated ResponseCache instances by introducing a shared cache (and a shared TTL constant) for multiple DiscourseAPI clients.
Changes:
- Added a
CACHE_TTLconstant inwebapp/utils/constants.pyfor cache TTL configuration. - Created a single
ubuntu_discourse_cacheinwebapp/app.pyand reused it across severalDiscourseAPIinstances. - Set
cache=Nonefor thediscuss.kubernetes.ioDiscourse instance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| webapp/utils/constants.py | Introduces a shared cache TTL constant for ResponseCache configuration. |
| webapp/app.py | Reuses a single ResponseCache across multiple Discourse API instances and adjusts caching behavior for an instance without API keys. |
Comments suppressed due to low confidence (1)
webapp/app.py:1172
- PR description says Discourse instances without API keys should have
cache=None, but this instance does not passapi_key/api_usernameand still uses the shared cache.
cache=ubuntu_discourse_cache,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2831 +/- ##
==========================================
+ Coverage 74.63% 74.65% +0.02%
==========================================
Files 19 19
Lines 2377 2379 +2
==========================================
+ Hits 1774 1776 +2
Misses 603 603
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
petesfrench
self-requested a review
August 4, 2026 09:36
petesfrench
reviewed
Aug 4, 2026
britneywwc
force-pushed
the
discourse-cache
branch
from
August 17, 2026 08:20
43cf781 to
7caf60b
Compare
britneywwc
force-pushed
the
discourse-cache
branch
from
August 19, 2026 07:01
6aaca5c to
ba55d13
Compare
britneywwc
force-pushed
the
discourse-cache
branch
from
August 20, 2026 06:12
ba55d13 to
65596b5
Compare
petesfrench
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
NoneQA
Issue / Card
Fixes WD-37940
Screenshots
[if relevant, include a screenshot]