Consolidate ESLint configs into root - #1324
Merged
Merged
Conversation
|
Size Change: 0 B 🆕 Total Size: 0 B |
✅ Deploy Preview for tourmaline-kringle-c98715 canceled.
|
captbaritone
force-pushed
the
consolidate-eslint-configs
branch
4 times, most recently
from
November 28, 2025 04:00
f1aaf4d to
7717fdd
Compare
Move general-purpose lint rules from packages/webamp/.eslintrc to the root .eslintrc so they apply to all packages consistently. This includes: - Core JavaScript best practices (no-var, prefer-const, eqeqeq, etc.) - TypeScript-specific rules (@typescript-eslint/no-unused-vars with patterns) - Prettier integration Package-specific configs now only contain rules unique to their needs: - webamp: React, import, and react-hooks plugin rules - skin-database: Extends @typescript-eslint/recommended, disables rules that conflict with existing code style - webamp-modern: Unchanged (has root: true for isolation) Also fixes lint errors in skin-database: - Consolidate duplicate imports in App.js and Feedback.js - Add radix parameter to parseInt - Prefix unused function parameters with underscore - Convert var to let/const - Fix type import for Shooter
captbaritone
force-pushed
the
consolidate-eslint-configs
branch
from
November 28, 2025 05:25
7717fdd to
54d5522
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates general-purpose ESLint rules from the various package-specific configs into the root
.eslintrc, making them apply consistently across all packages.What Changed
Root
.eslintrcMoved ~50 general-purpose rules that were previously only in
packages/webamp/.eslintrc:no-var,prefer-const,eqeqeq,no-eval, etc.max-depth,max-params,no-nested-ternary, etc.@typescript-eslint/no-unused-varswith underscore patterns for ignored varspackages/webamp/.eslintrcNow only contains React-specific configuration:
packages/skin-database/.eslintrc.js@typescript-eslint/recommendedcamelcase,dot-notation)packages/webamp-modern/.eslintrc.jsUnchanged - it has
root: trueso it's intentionally isolated from the root config.Lint Fixes
Also fixes existing lint errors in skin-database:
App.jsandFeedback.jsparseInt()vartolet/constTesting
npx turbo lintpasses on all packages