Potential fix for code scanning alert no. 84: Poor error handling: empty catch block#33
Merged
Conversation
…pty catch block Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/caveman8080/ACMECertManager/security/code-scanning/84
The best fix is to keep current behavior (no user-facing crash/popups) while making failures observable by logging each caught exception. In this file,
Microsoft.Extensions.Loggingis already imported, and_loggeris typically available in this codebase pattern, so the minimal safe change is to add_logger?.LogWarning(...)in each currently-empty catch block.Concretely in
src/MainWindow.xaml.cs, update the empty catches in:LoadPersistedLogs():IOException,UnauthorizedAccessException,SecurityExceptionIOException,UnauthorizedAccessException,SecurityExceptionUpdateLogStatistics():IOException,UnauthorizedAccessException,ObjectDisposedExceptionNo functional flow change is needed; only add warning logs with context messages.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.