Skip to content

Potential fix for code scanning alert no. 84: Poor error handling: empty catch block #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caveman8080 merged 1 commit into from
Jul 3, 2026
Merged

Potential fix for code scanning alert no. 84: Poor error handling: empty catch block #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions src/MainWindow.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,14 +1015,17 @@ private void LoadPersistedLogs()
var content = File.ReadAllText(logFiles[0]);
sb.Append(content);
}
catch (IOException)
catch (IOException ex)
{
_logger?.LogWarning(ex, "Failed to read persisted log file due to I/O error: {LogFilePath}", logFiles[0]);
}
catch (UnauthorizedAccessException)
catch (UnauthorizedAccessException ex)
{
_logger?.LogWarning(ex, "Access denied while reading persisted log file: {LogFilePath}", logFiles[0]);
}
catch (System.Security.SecurityException)
catch (System.Security.SecurityException ex)
{
_logger?.LogWarning(ex, "Security error while reading persisted log file: {LogFilePath}", logFiles[0]);
}
}

Expand All @@ -1034,14 +1037,17 @@ private void LoadPersistedLogs()

UpdateLogStatistics();
}
catch (IOException)
catch (IOException ex)
{
_logger?.LogWarning(ex, "I/O error occurred while loading persisted logs.");
}
catch (UnauthorizedAccessException)
catch (UnauthorizedAccessException ex)
{
_logger?.LogWarning(ex, "Access denied while loading persisted logs.");
}
catch (System.Security.SecurityException)
catch (System.Security.SecurityException ex)
{
_logger?.LogWarning(ex, "Security error while loading persisted logs.");
}
}

Expand All @@ -1058,14 +1064,17 @@ private void UpdateLogStatistics()

txtLogStats.Text = $"📊 Total: {totalSize:N0} bytes ({sizeMb:F2} MB) | Current: {currentSizeMb:F2} MB | Files: {fileCount}";
}
catch (IOException)
catch (IOException ex)
{
_logger?.LogWarning(ex, "I/O error occurred while updating log statistics.");
}
catch (UnauthorizedAccessException)
catch (UnauthorizedAccessException ex)
{
_logger?.LogWarning(ex, "Access denied while updating log statistics.");
}
catch (ObjectDisposedException)
catch (ObjectDisposedException ex)
{
_logger?.LogWarning(ex, "Log manager was disposed while updating log statistics.");
}
}

Expand Down
Loading