Fix memory leak - #31
Merged
Merged
Conversation
This change adds the leak_tracker_flutter_testing package to the dev_dependencies in pubspec.yaml and creates a new test configuration file for enabling leak detection during tests.
…orBaseState Added a dispose method to the CountrySelectorBaseState class to ensure the controller is disposed of correctly, preventing potential memory leaks.
Add entry for version 1.0.17 to the changelog, documenting the fix for a memory leak in the CountrySelectorBase widget.
Owner
|
thanks
While reading the documentation, it seems to me that the tests should use |
Contributor
Author
|
Based on this documentation, After that, all the testWidgets will be tracked for not disposed and not GCed objects. |
Contributor
Author
|
Thanks @cedvdb for accepting the PR. Please don't forget to push it to the pub.dev. |
Owner
|
Thanks ! It was published on pub dev for version 1.0.17 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in the CountrySelectorBase widget, where the CountrySelectorController hasn't been disposed in the dispose method. Also added
leak_tracker_flutter_testingto the dev dependencies to automatically track memory leaks.Closes #30
Checklist