[ENH](wal3): Trim body metadata - #7645
Open
domenkozar wants to merge 1 commit into
Open
Conversation
Disable Parquet statistics for opaque log bodies. Large records no longer get copied repeatedly into min/max metadata. Keep offset and timestamp statistics. Cover fragment size, round-trip decoding, and setsum verification with a regression test.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Author
|
cc @rescrv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parquet's page-statistics default copies a single large binary value into min/max metadata multiple times. A focused probe reduced a roughly 2 MB one-record fragment from 10.24 MB to 2.05 MB. Existing fragments remain readable because this changes writer properties only.
S3 request count is unchanged, while fragment storage and transfer bytes drop substantially for large records.
Tests
Tilt-backed integration tests were not validated locally because the required services were not active.