Skip to content

[16.0.X] Pixel CPE Generic-only era modifier#50497

Merged
cmsbuild merged 1 commit intocms-sw:CMSSW_16_0_Xfrom
mroguljic:160X_2026_CPEGeneric_modifier
Mar 24, 2026
Merged

[16.0.X] Pixel CPE Generic-only era modifier#50497
cmsbuild merged 1 commit intocms-sw:CMSSW_16_0_Xfrom
mroguljic:160X_2026_CPEGeneric_modifier

Conversation

@mroguljic
Copy link
Copy Markdown
Contributor

PR description:

This PR adds a modifier to the Run 3 2026 era configuration that makes the PixelRecHits ESProducers use Generic CPE. The PR is created in case of a possible change in reconstruction during 2026 data-taking.

PR validation:

Tested at configuration level with

cmsDriver.py step3 --era Run3_2026 --conditions auto:run3_data --data -s RECO --no_exec -n 1 --python_filename test_Run3_SiPixelGenericCPE_2026.py
edmConfigDump test_Run3_SiPixelGenericCPE_2026.py >& alternative.txt

The full configuration, w.r.t. the unmodified configuration, only differs in the PixelCPE parameter for the two TkTransientTrackingRecHitBuilderESProducer for

src$ diff alternative.txt central.txt 
85755c85755
<     PixelCPE = cms.string('PixelCPEGeneric'),
---
>     PixelCPE = cms.string('PixelCPEClusterRepair'),
85766c85766
<     PixelCPE = cms.string('PixelCPEGeneric'),
---
>     PixelCPE = cms.string('PixelCPEClusterRepairWithoutProbQ'),

The producers, with the change included, are shown below

process.TTRHBuilderAngleAndTemplate = cms.ESProducer("TkTransientTrackingRecHitBuilderESProducer",
    ComponentName = cms.string('WithAngleAndTemplate'),
    ComputeCoarseLocalPositionFromDisk = cms.bool(False),
    Matcher = cms.string('StandardMatcher'),
    Phase2StripCPE = cms.string(''),
    PixelCPE = cms.string('PixelCPEGeneric'),
    StripCPE = cms.string('StripCPEfromTrackAngle'),
    appendToDataLabel = cms.string('')
)


process.TTRHBuilderAngleAndTemplateWithoutProbQ = cms.ESProducer("TkTransientTrackingRecHitBuilderESProducer",
    ComponentName = cms.string('WithAngleAndTemplateWithoutProbQ'),
    ComputeCoarseLocalPositionFromDisk = cms.bool(False),
    Matcher = cms.string('StandardMatcher'),
    Phase2StripCPE = cms.string(''),
    PixelCPE = cms.string('PixelCPEGeneric'),
    StripCPE = cms.string('StripCPEfromTrackAngle'),
    appendToDataLabel = cms.string('')
)

Changes are expected in all workflows that use Run3 2026 era modifier.

Backport of #50480

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 23, 2026

A new Pull Request was created by @mroguljic for CMSSW_16_0_X.

It involves the following packages:

  • Configuration/Eras (operations)

@cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 23, 2026

cms-bot internal usage

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 23, 2026

backport of #50480

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 23, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d46a46/52166/summary.html
COMMIT: b3d9c6c
CMSSW: CMSSW_16_0_X_2026-03-23-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50497/52166/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1466 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4221 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4166533
  • DQMHistoTests: Total failures: 3482
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4163031
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@vlimant
Copy link
Copy Markdown
Contributor

vlimant commented Mar 24, 2026

assign ppd

@cmsbuild
Copy link
Copy Markdown
Contributor

New categories assigned: ppd

@abenecke,@vlimant you have been requested to review this Pull request/Issue and eventually sign? Thanks

@vlimant
Copy link
Copy Markdown
Contributor

vlimant commented Mar 24, 2026

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link
Copy Markdown

+1

@cmsbuild cmsbuild merged commit 9b7a8c1 into cms-sw:CMSSW_16_0_X Mar 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants