Skip to content

perf: Eagerly load comparison commits and repositories#786

Merged
thomasrockhu-codecov merged 2 commits intomainfrom
seer/perf/eager-load-comparison-commits
Mar 30, 2026
Merged

perf: Eagerly load comparison commits and repositories#786
thomasrockhu-codecov merged 2 commits intomainfrom
seer/perf/eager-load-comparison-commits

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Mar 29, 2026

Fixes WORKER-PG0. The issue was that: ComputeComparison task's component iteration repeatedly lazy-loads Commit, Repository, and Owner objects, causing N+1 database queries.

  • Added joinedload options to the CompareCommit query.
  • Eagerly loads the 'compare_commit' and its related 'repository' and 'author'.
  • Eagerly loads the 'base_commit' and its related 'repository'.
  • Improves performance by reducing N+1 database queries when fetching comparison details.

This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 12511278

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk performance change limited to ORM query loading behavior; primary risk is unintended extra/incorrect eager loads or masking missing relationships at runtime.

Overview
Reduces N+1 queries in ComputeComparisonTask. The CompareCommit lookup now uses SQLAlchemy joinedload to eagerly fetch the compare_commit (and its repository and author) and the base_commit (and its repository), avoiding repeated lazy-loads during comparison/component iteration.

Written by Cursor Bugbot for commit 8f89c04. This will update automatically on new commits. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (13ff78c) to head (8f89c04).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #786   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1305     1305           
  Lines       47981    47983    +2     
  Branches     1636     1636           
=======================================
+ Hits        44263    44265    +2     
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.57% <100.00%> (+<0.01%) ⬆️
workerunit 90.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Co-authored-by: Tom Hu <88201630+thomasrockhu-codecov@users.noreply.github.com>
@thomasrockhu-codecov thomasrockhu-codecov added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit d005280 Mar 30, 2026
40 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the seer/perf/eager-load-comparison-commits branch March 30, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant