Skip to content

perf: Eagerly load comparison commits and repositories #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasrockhu-codecov merged 2 commits into from
Mar 30, 2026
+12 −1
Merged

perf: Eagerly load comparison commits and repositories #786

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3752826
perf: Eagerly load comparison commits and repositories
sentry[bot] Mar 29, 2026
8f89c04
Apply suggestions from code review
thomasrockhu-codecov Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion apps/worker/tasks/compute_comparison.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@
import sentry_sdk
from asgiref.sync import async_to_sync
from celery import group
from sqlalchemy.orm import joinedload

from app import celery_app
from database.enums import CompareCommitError, CompareCommitState
from database.models import CompareCommit, CompareComponent, CompareFlag
from database.models.core import Commit, Repository
from database.models.reports import RepositoryFlag
from helpers.comparison import minimal_totals
from helpers.github_installation import get_installation_name_for_owner_for_task
Expand Down Expand Up @@ -45,7 +47,16 @@ class ComputeComparisonTask(BaseCodecovTask, name=compute_comparison_task_name):
def run_impl(
self, db_session, comparison_id, *args, **kwargs
) -> ComputeComparisonTaskReturn:
comparison: CompareCommit = db_session.query(CompareCommit).get(comparison_id)
comparison: CompareCommit = (
db_session.query(CompareCommit)
.options(
joinedload(CompareCommit.compare_commit)
.joinedload(Commit.repository)
.joinedload(Repository.author),
joinedload(CompareCommit.base_commit).joinedload(Commit.repository),
)
.get(comparison_id)
)
repo = comparison.compare_commit.repository
log_extra = {
"comparison_id": comparison_id,
Expand Down
Loading