feat: add relative submodule URL resolution to rattler_git#2320
Open
Hofer-Julian wants to merge 1 commit intoconda:mainfrom
Open
feat: add relative submodule URL resolution to rattler_git#2320Hofer-Julian wants to merge 1 commit intoconda:mainfrom
Hofer-Julian wants to merge 1 commit intoconda:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in prefix-dev/rattler-build#2401, we want all git related operations to be bundled in
rattler_git. So I move the submodule resolving here.Originally submodules with relative paths failed since we first check them out and then
git clone --localwhich hard-links and keeps the original relative path intact. That doesn't result into the paths we want, so we make them absolute with the original path as referenceHow Has This Been Tested?
AI Disclosure
Tools: Claude
Checklist: