chore(deps): update dependency golangci/golangci-lint to v2.3.0

[renovate]

This PR contains the following updates:

Package	Update	Change
golangci/golangci-lint	minor	v2.2.2 -> v2.3.0

---

Release Notes

golangci/golangci-lint (golangci/golangci-lint)

v2.3.0

Compare Source

1. Linters new features or changes
   • ginkgolinter: from 0.19.1 to 0.20.0 (new option: force-assertion-description)
   • iface: from 1.4.0 to 1.4.1 (report message improvements)
   • noctx: from 0.3.4 to 0.3.5 (new detections: log/slog, exec, crypto/tls)
   • revive: from 1.10.0 to 1.11.0 (new rule: enforce-switch-style)
   • wsl: from 5.0.0 to 5.1.0
2. Linters bug fixes
   • gosec: from 2.22.5 to 2.22.6
   • noinlineerr: from 1.0.4 to 1.0.5
   • sloglint: from 0.11.0 to 0.11.1
3. Misc.
   • fix: panic close of closed channel

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[giuseppe]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, renovate[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [giuseppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

@giuseppe Looks like you merged this without passing validate job which means no the linter is failing on all PRs.

Merge protection for the github action stuff is not set up here (something we should fix of course), I can fix the few lints later unless you like to do it.

[giuseppe]

sorry, I will take care of these and open a new PR

[giuseppe]

do you prefer to drop the noctx linter or adapt all our calls to the reported functions?

I am not sure the resulting code is nicer when we add dummycontext.Background()` argument to all the exec.Command calls we have

[Luap99]

I am fine dropping the linter (or maybe just silence it on the reported case so we still have it for new code). I agree in the currently reported places there doesn't seem to be a need for passing a context and and if there is no parent context then passing context.Background() doesn't add anything useful.

[Luap99]

sorry, I will take care of these and open a new PR

yeah no worries I updated the merge protection rules here just now to include both githaub actions so this should not happen again.

[giuseppe]

I've opened a PR with the reported issues, to get a better idea: #2484

[giuseppe]

and the alternative to just disable the linter: #2485

Pick the one you prefer :-)