golangci-lint: fix all the reported lint errors - #2484
Closed
giuseppe wants to merge 1 commit into
Closed
Conversation
Reviewer's GuideThis PR migrates synchronous exec.Command, net.Listen, and net.Dial calls to their context-aware variants using context.Background, addressing lint errors introduced by the updated golangci-lint rules. Class diagram for updated usage of exec and net packagesclassDiagram
class exec {
+Command(name string, arg ...string) *Cmd
+CommandContext(ctx context.Context, name string, arg ...string) *Cmd
}
class net {
+Dial(network, address string) (Conn, error)
+Dialer
+Dialer.DialContext(ctx context.Context, network, address string) (Conn, error)
}
class context {
+Background() Context
}
exec <.. context : uses
net <.. context : uses
net <|-- net.Dialer
net.Dialer <.. context : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, sourcery-ai[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
commit 2d75d8e bumped the linter version without fixing the new issues. Follow-up for containers#2482 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
fix-golang-lint-errors
branch
from
July 23, 2025 12:10
e3b7c05 to
6a74d9f
Compare
1 task
giuseppe
marked this pull request as draft
July 23, 2025 12:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 2d75d8e bumped the linter version without fixing the new issues.
Follow-up for #2482
Summary by Sourcery
Fix all reported lint errors by replacing context-less calls to exec.Command, net.Listen, and net.Dial with their context-aware counterparts across the codebase.
Enhancements: