Fix client_ip in logger http.handlers.waf#306
Conversation
In addition to the pull request https://github.com/corazawaf/coraza-caddy/pull/184/changes for setting the correct client_ip IP via getClientAddress, the generation of the error log with the correct IP has been left out of the change.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates error logging for WAF rule violations in ChangesWAF violation error logging
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Can you add tests, please? |
In addition to the pull request https://github.com/corazawaf/coraza-caddy/pull/184/changes for setting the correct client_ip IP via getClientAddress, the generation of the error log with the correct IP has been left out of the change.
Summary by CodeRabbit