Skip to content

Fix type annotation of download_kwargs#146

Merged
cthoyt merged 2 commits into
mainfrom
fix-kwargs
Apr 20, 2026
Merged

Fix type annotation of download_kwargs#146
cthoyt merged 2 commits into
mainfrom
fix-kwargs

Conversation

@cthoyt

@cthoyt cthoyt commented Apr 20, 2026

Copy link
Copy Markdown
Owner

Closes #145

This PR extends the RequestKwargs type dictionary with the other parts that are needed to call the pystow.utils.download() function

@cthoyt cthoyt marked this pull request as ready for review April 20, 2026 07:55
@codecov

codecov Bot commented Apr 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.81%. Comparing base (fe6d8ba) to head (1c66762).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   75.72%   75.81%   +0.09%     
==========================================
  Files          17       17              
  Lines        1767     1774       +7     
  Branches      211      211              
==========================================
+ Hits         1338     1345       +7     
  Misses        336      336              
  Partials       93       93              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cthoyt cthoyt changed the title Fix keyword argument pass Fix type annotation of download_kwargs Apr 20, 2026
@cthoyt cthoyt merged commit 496430d into main Apr 20, 2026
13 checks passed
@cthoyt cthoyt deleted the fix-kwargs branch April 20, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Key backend is missing from RequestKwargs type

1 participant