Add testdata where steps are prefixes of other steps#402
Merged
mpkorstanje merged 2 commits intomainfrom May 25, 2025
Merged
Conversation
This was referenced May 23, 2025
11e411e to
e46136d
Compare
7 tasks
Contributor
|
Are the newly added .ndjson files valid? While working on #405, I used the test data. Should we adjust the files or change the .NET Spec/UnitTest implementation? |
Contributor
Author
|
Ah, no that's my bad! Should be a single line. Though for this repository I wouldn't expect the test suite to interact with the data. Other than through make. |
7 tasks
Contributor
|
The .NET tests only read the test data. Currently, they fail if the data is not formatted correctly. I opened issue #406 to make the .NET implementation more robust. |
Verify which implementations are affected by #400
1a8bdb2 to
a06bc0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚡️ What's your motivation?
Verify which implementations are affected by #400
🏷️ What kind of change is this?
📋 Checklist: