Skip to content

Add testdata where steps are prefixes of other steps#402

Merged
mpkorstanje merged 2 commits intomainfrom
fix/prefer-longest-step-keyword
May 25, 2025
Merged

Add testdata where steps are prefixes of other steps#402
mpkorstanje merged 2 commits intomainfrom
fix/prefer-longest-step-keyword

Conversation

@mpkorstanje
Copy link
Copy Markdown
Contributor

⚡️ What's your motivation?

Verify which implementations are affected by #400

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje force-pushed the fix/prefer-longest-step-keyword branch from 11e411e to e46136d Compare May 23, 2025 12:42
@stof stof mentioned this pull request May 23, 2025
7 tasks
@mpkorstanje mpkorstanje changed the title Add testdata with where steps are prefixes of other steps Add testdata where steps are prefixes of other steps May 23, 2025
@obligaron
Copy link
Copy Markdown
Contributor

Are the newly added .ndjson files valid?

While working on #405, I used the test data.
However, they failed for the current .NET Spec/UnitTest implementation because the test infrastructure expects the test data to contain only one JSON object per line.
For my pull request, I manually changed the test data.

Should we adjust the files or change the .NET Spec/UnitTest implementation?

@mpkorstanje
Copy link
Copy Markdown
Contributor Author

Ah, no that's my bad! Should be a single line. Though for this repository I wouldn't expect the test suite to interact with the data. Other than through make.

@obligaron
Copy link
Copy Markdown
Contributor

The .NET tests only read the test data. Currently, they fail if the data is not formatted correctly. I opened issue #406 to make the .NET implementation more robust.

@mpkorstanje mpkorstanje force-pushed the fix/prefer-longest-step-keyword branch from 1a8bdb2 to a06bc0e Compare May 25, 2025 16:32
@mpkorstanje mpkorstanje marked this pull request as ready for review May 25, 2025 19:12
@mpkorstanje mpkorstanje merged commit c6f6937 into main May 25, 2025
23 of 34 checks passed
@mpkorstanje mpkorstanje deleted the fix/prefer-longest-step-keyword branch May 25, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants