Skip to content

[.NET] More robust ndjson handling for Spec/UnitTests#406

Merged
mpkorstanje merged 1 commit intocucumber:mainfrom
obligaron:refactor/testndjson
Jun 30, 2025
Merged

[.NET] More robust ndjson handling for Spec/UnitTests#406
mpkorstanje merged 1 commit intocucumber:mainfrom
obligaron:refactor/testndjson

Conversation

@obligaron
Copy link
Copy Markdown
Contributor

🤔 What's changed?

This PR only modifies the Spec/UnitTests, not any shipped artifacts (e.g., NuGet assemblies).

⚡️ What's your motivation?

While working on #405, it was discovered that the .NET tests are not as robust as other implementations when handling ndjson files. See comment in #402 (comment).

This also improves the test runtime (on my machine) from 3.5 seconds to 2.5 seconds and avoids file lock errors when running the tests on Windows.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@obligaron obligaron force-pushed the refactor/testndjson branch from 3ecc963 to 3cedc21 Compare May 29, 2025 08:37
@clrudolphi clrudolphi self-requested a review June 30, 2025 13:05
Copy link
Copy Markdown
Contributor

@clrudolphi clrudolphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mpkorstanje mpkorstanje merged commit 55955f4 into cucumber:main Jun 30, 2025
2 checks passed
@obligaron obligaron deleted the refactor/testndjson branch June 30, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants