benchmark.sh: apply PR #202 review-thread fixes for parsing, warnings, and portability#203
Closed
Copilot wants to merge 2 commits into
Closed
benchmark.sh: apply PR #202 review-thread fixes for parsing, warnings, and portability#203Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comments
benchmark.sh: apply PR #202 review-thread fixes for parsing, warnings, and portability
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
benchmark.shto resolve all comments in the referenced PR review thread, applying the requested behavior changes directly. The fixes are scoped to portability, timing-value parsing, warning criteria, and summary wording.Portable temp file creation
mktempwith a template-backed invocation so the script works on macOS/BSD and Linux variants.Timing parse normalization (
zero→0)parse_dtest_outputto normalizedtest’s literalzerotiming output to numeric0for parsed user/sys/avg fields.Warning signal narrowed to required fields
user,sys) are missing, avoiding false warnings when optional fields are absent.Summary wording aligned with actual computation