feat: add set public button to photo view - #4594
Conversation
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
This method swaps also additionally added sprites.
This method swaps also additionally added sprites.
b38ffa8 to
2f8fbbf
Compare
DafGreco
left a comment
There was a problem hiding this comment.
✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- [✔️ ] Backpack and wearables in world
- [✔️ ] Emotes in world and in backpack
- [✔️ ] Teleport with map/coordinates/Jump In
- [✔️ ] Chat and multiplayer
- [✔️ ] Profile card
- [✔️ ] Camera
- [✔️ ] Settings
Evidence:
toggle.mp4
# Conflicts: # Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/CameraReelController.cs # Explorer/Assets/DCL/Infrastructure/Global/Dynamic/DynamicWorldContainer.cs # Explorer/Assets/DCL/PluginSystem/Global/ExplorePanelPlugin.cs # Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
# Conflicts: # Explorer/Assets/DCL/Infrastructure/Global/Dynamic/DynamicWorldContainer.cs # Explorer/Assets/DCL/Passport/PassportController.cs # Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset # Explorer/Assets/DCL/PluginSystem/Global/PassportPlugin.cs
There was a problem hiding this comment.
✔️ Reviewed on Windows and working as expected.
✔️ The toggle was turned on and off from:
- Camera reel pressing K
- Camera reel accesing through the navbar
- Photos set as public on My Profile
- After taking a photo and opening the reel
- From inside the photo description
- From outside with the three dots
✔️ Hiding photos from My Profile moves the reel to the next public one
✔️ Hiding all public fotos on My Profile leads to the correct empty state
14.07.2025_08.33.19_REC.mp4
14.07.2025_08.37.27_REC.mp4
14.07.2025_08.36.02_REC.mp4
Awaiting for approval on Mac
There was a problem hiding this comment.
✅ What works correctly:
- Photos marked as public from the gallery (kebab menu and photo detail) appear properly in the user’s Passport.
- Public photos also show up in the Photos tab of the scene.
- The notification about the visibility change is triggered as expected.
- This happens on both platforms: after setting a photo as public from the Photo Details panel, the confirmation notification appears, but the toggle still looks off (both in the kebab menu and the Photo Details). Despite that, the photo is correctly listed in the Passport and scene. The toggle only updates visually after re-entering the gallery.
We resolve to create a separate ticket for this issue.
mac.mp4
# Conflicts: # Explorer/Assets/DCL/Communities/CommunitiesCard/CommunityCardController.cs # Explorer/Assets/DCL/Passport/PassportController.cs # Explorer/Assets/DCL/PluginSystem/Global/CommunitiesPlugin.cs # Explorer/Assets/DCL/PluginSystem/Global/ExplorePanelPlugin.cs # Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset # Explorer/Assets/DCL/PluginSystem/Global/PassportPlugin.cs
# Conflicts: # Explorer/Assets/DCL/Infrastructure/Global/Dynamic/DynamicWorldContainer.cs # Explorer/Assets/DCL/Passport/PassportController.cs # Explorer/Assets/DCL/PluginSystem/Global/ExplorePanelPlugin.cs # Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
Ludmilafantaniella
left a comment
There was a problem hiding this comment.
✅ Tested on both Windows and Mac, covering the following scenarios:
🧵Thread for more info.
- Opening Photo Details panel from:
- Passport gallery
- Location gallery
- Gallery via ‘K’ shortcut
- Setting reels as public and private using both:
- The three dots menu
- The Set as Public toggle within the Photo Details panel
- Verified expected behavior after setting reels to private:
- If opened from the passport, correctly switches to the next reel or closes the panel when no reels are left
- The gallery view updates accordingly
- Verified that Set as Public/Delete options are correctly disabled in public galleries
- No issues found, all toasts display properly and state changes are reflected as expected
Everything working as intended ✅
Great improvement to the flow!
4594-evidence.mp4
✅ Regressions performed in order:
- ✔️ Backpack and wearables in world
- ✔️ Emotes in world and in backpack
- ✔️ Teleport with map/coordinates/Jump In
- ✔️ Chat and multiplayer
- ✔️ Profile card
- ✔️ Camera
- ✔️ Skybox
- ✔️ Settings
DafGreco
left a comment
There was a problem hiding this comment.
✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- [ ✔️] Log In/Log Out
- [✔️ ] Backpack and wearables in world
- [✔️ ] Emotes in world and in backpack
- [✔️] Teleport with map/coordinates/Jump In
- [✔️ ] Chat and multiplayer
- [✔️ ] Profile card
- [ ✔️] Camera
- [✔️ ] Skybox
- [✔️ ] Settings
Thread of evidence
Things verified on this PR :
- Toggle ON/OFF particular
- Profile Toggle ON/OFF
- Camera Gallery toggle On / OFF
- Text of toggle ON/OFF
Screen.Recording.2025-07-28.at.12.15.58.mov
davidejensen
left a comment
There was a problem hiding this comment.
Other than the exception issue it's good!
# Conflicts: # Explorer/Assets/DCL/Communities/CommunitiesCard/CommunityCardController.cs # Explorer/Assets/DCL/PluginSystem/Global/CommunitiesPlugin.cs # Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset

Pull Request Description
Fix #3206
What does this PR change?
Hiding reel in this way, reorganizes reels in passport's gallery.
Test Instructions
Prerequisites
Test Steps
If Photo Details was opened from player's passport gallery it additionally will switch to next reel, or if there's no reels in gallery left, it will close Photo Details panel, and update gallery panel without recently set private reels
2025-07-01.16-12-00.mp4
Quality Checklist
Code Review Reference
Please review our Code Review Standards before submitting.