Skip to content

feat: add set public button to photo view - #4594

Merged
krzysztof-murczynski merged 27 commits into
devfrom
feat/Add-set-public-button-to-photo-view
Jul 29, 2025
Merged

feat: add set public button to photo view#4594
krzysztof-murczynski merged 27 commits into
devfrom
feat/Add-set-public-button-to-photo-view

Conversation

@krzysztof-murczynski

@krzysztof-murczynski krzysztof-murczynski commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

Pull Request Description

Fix #3206

What does this PR change?

  • Introduced Set as Public toggle in Photo Details panel Add 'Set as Public' toggle on the detailed view of a photo #3206
  • Disabled Set as Public and Delete Button from public galleries (location gallery and other people passport).
  • Setting reel to private, from player's passport's gallery will switch to next reel, or close Photo Details panel if there are no reels left.
    Hiding reel in this way, reorganizes reels in passport's gallery.

obraz

Test Instructions

  • During tests, enter reel's Photo Detail panel from different panels (from Passpost's gallery, Location gallery and Gallery from keyboard shortcut 'K')
  • While in Photo Details panel opened from player's passport (obraz) switch to next/previous reels, set your reel to private, and observe if everything works like it should.

Prerequisites

  • Account with at least 2 reels shot from same location

Test Steps

  1. Enter reel shot functionality with 'C' shortcut and shot at least 2 reels
  2. Enter your Gallery with 'K' shortcut, and set these reels as public by either clicking 3 dots in right corner of reel thumbnail, or by entering Photo Details panel (try doing both during testing)
    image
    obraz
  3. Open Photo Details panel from player passport or gallery 'K' shortcut)
  4. Set reel as private
  5. Expected behavior: If reel was set as private from Gallery 'K', reel will be set at private, and user will get this notification
    obraz
    If Photo Details was opened from player's passport gallery it additionally will switch to next reel, or if there's no reels in gallery left, it will close Photo Details panel, and update gallery panel without recently set private reels
2025-07-01.16-12-00.mp4

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@github-actions

github-actions Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

Comment thread Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetailController.cs Outdated
Comment thread Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetailController.cs Outdated
Comment thread Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetailController.cs Outdated
@krzysztof-murczynski
krzysztof-murczynski force-pushed the feat/Add-set-public-button-to-photo-view branch from b38ffa8 to 2f8fbbf Compare July 1, 2025 17:35
@davidejensen
davidejensen marked this pull request as ready for review July 2, 2025 07:45
@davidejensen
davidejensen requested review from a team as code owners July 2, 2025 07:45

@DafGreco DafGreco left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • [✔️ ] Backpack and wearables in world
  • [✔️ ] Emotes in world and in backpack
  • [✔️ ] Teleport with map/coordinates/Jump In
  • [✔️ ] Chat and multiplayer
  • [✔️ ] Profile card
  • [✔️ ] Camera
  • [✔️ ] Settings

Evidence:

toggle.mp4

# Conflicts:
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/CameraReelController.cs
#	Explorer/Assets/DCL/Infrastructure/Global/Dynamic/DynamicWorldContainer.cs
#	Explorer/Assets/DCL/PluginSystem/Global/ExplorePanelPlugin.cs
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
# Conflicts:
#	Explorer/Assets/DCL/Infrastructure/Global/Dynamic/DynamicWorldContainer.cs
#	Explorer/Assets/DCL/Passport/PassportController.cs
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
#	Explorer/Assets/DCL/PluginSystem/Global/PassportPlugin.cs
@anicalbano
anicalbano self-requested a review July 14, 2025 11:40

@anicalbano anicalbano left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Reviewed on Windows and working as expected.
✔️ The toggle was turned on and off from:

  • Camera reel pressing K
  • Camera reel accesing through the navbar
  • Photos set as public on My Profile
  • After taking a photo and opening the reel
  • From inside the photo description
  • From outside with the three dots

✔️ Hiding photos from My Profile moves the reel to the next public one
✔️ Hiding all public fotos on My Profile leads to the correct empty state

14.07.2025_08.33.19_REC.mp4
14.07.2025_08.37.27_REC.mp4
14.07.2025_08.36.02_REC.mp4

Awaiting for approval on Mac

@Ludmilafantaniella Ludmilafantaniella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ What works correctly:

  • Photos marked as public from the gallery (kebab menu and photo detail) appear properly in the user’s Passport.
  • Public photos also show up in the Photos tab of the scene.
  • The notification about the visibility change is triggered as expected.

⚠️ Minor (non-functional) visual glitch:

  • This happens on both platforms: after setting a photo as public from the Photo Details panel, the confirmation notification appears, but the toggle still looks off (both in the kebab menu and the Photo Details). Despite that, the photo is correctly listed in the Passport and scene. The toggle only updates visually after re-entering the gallery.
    We resolve to create a separate ticket for this issue.
mac.mp4
Screenshot at Jul 14 10-24-41 Screenshot at Jul 14 10-26-23

@krzysztof-murczynski krzysztof-murczynski changed the title Feat/add set public button to photo view feat/: add set public button to photo view Jul 16, 2025
@krzysztof-murczynski krzysztof-murczynski changed the title feat/: add set public button to photo view feat: add set public button to photo view Jul 16, 2025
# Conflicts:
#	Explorer/Assets/DCL/Communities/CommunitiesCard/CommunityCardController.cs
#	Explorer/Assets/DCL/Passport/PassportController.cs
#	Explorer/Assets/DCL/PluginSystem/Global/CommunitiesPlugin.cs
#	Explorer/Assets/DCL/PluginSystem/Global/ExplorePanelPlugin.cs
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
#	Explorer/Assets/DCL/PluginSystem/Global/PassportPlugin.cs
# Conflicts:
#	Explorer/Assets/DCL/Infrastructure/Global/Dynamic/DynamicWorldContainer.cs
#	Explorer/Assets/DCL/Passport/PassportController.cs
#	Explorer/Assets/DCL/PluginSystem/Global/ExplorePanelPlugin.cs
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
@Ludmilafantaniella
Ludmilafantaniella self-requested a review July 25, 2025 16:44

@Ludmilafantaniella Ludmilafantaniella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested on both Windows and Mac, covering the following scenarios:

🧵Thread for more info.

  • Opening Photo Details panel from:
    • Passport gallery
    • Location gallery
    • Gallery via ‘K’ shortcut
  • Setting reels as public and private using both:
    • The three dots menu
    • The Set as Public toggle within the Photo Details panel
  • Verified expected behavior after setting reels to private:
    • If opened from the passport, correctly switches to the next reel or closes the panel when no reels are left
    • The gallery view updates accordingly
  • Verified that Set as Public/Delete options are correctly disabled in public galleries
  • No issues found, all toasts display properly and state changes are reflected as expected

Everything working as intended ✅
Great improvement to the flow!

4594-evidence.mp4

✅ Regressions performed in order:

  • ✔️ Backpack and wearables in world
  • ✔️ Emotes in world and in backpack
  • ✔️ Teleport with map/coordinates/Jump In
  • ✔️ Chat and multiplayer
  • ✔️ Profile card
  • ✔️ Camera
  • ✔️ Skybox
  • ✔️ Settings

@DafGreco
DafGreco self-requested a review July 28, 2025 11:13

@DafGreco DafGreco left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • [ ✔️] Log In/Log Out
  • [✔️ ] Backpack and wearables in world
  • [✔️ ] Emotes in world and in backpack
  • [✔️] Teleport with map/coordinates/Jump In
  • [✔️ ] Chat and multiplayer
  • [✔️ ] Profile card
  • [ ✔️] Camera
  • [✔️ ] Skybox
  • [✔️ ] Settings

Thread of evidence
Things verified on this PR :

  • Toggle ON/OFF particular
  • Profile Toggle ON/OFF
  • Camera Gallery toggle On / OFF
  • Text of toggle ON/OFF

Evidence:
Screenshot 2025-07-28 at 12 15 52

Screen.Recording.2025-07-28.at.12.15.58.mov

@davidejensen davidejensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the exception issue it's good!

Comment thread Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetailController.cs Outdated
# Conflicts:
#	Explorer/Assets/DCL/Communities/CommunitiesCard/CommunityCardController.cs
#	Explorer/Assets/DCL/PluginSystem/Global/CommunitiesPlugin.cs
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
@krzysztof-murczynski
krzysztof-murczynski enabled auto-merge (squash) July 29, 2025 12:17
@krzysztof-murczynski
krzysztof-murczynski merged commit 1086ab9 into dev Jul 29, 2025
6 checks passed
@krzysztof-murczynski
krzysztof-murczynski deleted the feat/Add-set-public-button-to-photo-view branch July 29, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 'Set as Public' toggle on the detailed view of a photo

5 participants