-
Notifications
You must be signed in to change notification settings - Fork 17
feat: add set public button to photo view #4594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
krzysztof-murczynski
merged 27 commits into
dev
from
feat/Add-set-public-button-to-photo-view
Jul 29, 2025
Merged
Changes from 24 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
c6efca7
Added Set as Public button to photo details panel
krzysztof-murczynski f830e4b
Added hide reels from public boards + hiding delete button on not own…
krzysztof-murczynski 43e92a5
Added separator hiding in pair with Set as Public toggle
krzysztof-murczynski 1c0c6be
Added SetInteractable method to ToggleWithText
krzysztof-murczynski 5f0bddb
Added SetInteractable to Button
krzysztof-murczynski ca2f37f
Added newly added SetInteractable to PhotoDetailUI
krzysztof-murczynski e51e982
Added color change to toggle on set interactable
krzysztof-murczynski c1af82d
Code clean up + toggle color scheme
krzysztof-murczynski 5102e8f
Added color change to text in ToggleWithText on noninteractive
krzysztof-murczynski 7d1e5c0
Code cleanup
krzysztof-murczynski c847deb
Disabled toggle and delete button for non player galleries
krzysztof-murczynski 2f8fbbf
Code cleanup
krzysztof-murczynski eef89a8
Merge branch 'dev' into feat/Add-set-public-button-to-photo-view
davidejensen 4e3d4b4
Added event bus to photo gallery to update public state in between pa…
krzysztof-murczynski 4c8fb79
Merge branch 'dev' into feat/Add-set-public-button-to-photo-view
krzysztof-murczynski f430782
Merge branch 'dev' into feat/Add-set-public-button-to-photo-view
krzysztof-murczynski 7624738
Hidden public toggle from community gallery + post merge fix
krzysztof-murczynski 9bfc74c
Merge branch 'dev' into feat/Add-set-public-button-to-photo-view
krzysztof-murczynski 8a972e3
Merge branch 'dev' into feat/Add-set-public-button-to-photo-view
krzysztof-murczynski 4cf5cbd
Merge branch 'dev' into feat/Add-set-public-button-to-photo-view
krzysztof-murczynski 3a96242
Merge branch 'dev' into feat/Add-set-public-button-to-photo-view
krzysztof-murczynski 7155335
Fixed post merge missing coma
krzysztof-murczynski 92a246d
Added reel updated text to global plugins settings
krzysztof-murczynski a2f27a6
Fixed reel set as public communication between panels
krzysztof-murczynski 6d239ca
Merge branch 'dev' into feat/Add-set-public-button-to-photo-view
krzysztof-murczynski b69d150
Implemented proper null handling to PhotoDetailController
krzysztof-murczynski 315b869
Merge branch 'dev' into feat/Add-set-public-button-to-photo-view
krzysztof-murczynski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
Explorer/Assets/DCL/InWorldCamera/PhotoDetail/GalleryEventBus.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| using System; | ||
|
|
||
| namespace DCL.InWorldCamera | ||
| { | ||
| public class GalleryEventBus | ||
| { | ||
| public event Action<string, bool> ReelPublicStateChangeEvent; | ||
|
|
||
| public void ReelPublicStateChanged(string reelId, bool isPublic) | ||
| { | ||
| ReelPublicStateChangeEvent?.Invoke(reelId, isPublic); | ||
| } | ||
| } | ||
| } |
3 changes: 3 additions & 0 deletions
3
Explorer/Assets/DCL/InWorldCamera/PhotoDetail/GalleryEventBus.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.