Skip to content

fix: reconciliation of global entities position after the scene has concluded - #8828

Merged
mikhail-dcl merged 1 commit into
devfrom
fix/sync-global-transform
May 20, 2026
Merged

fix: reconciliation of global entities position after the scene has concluded#8828
mikhail-dcl merged 1 commit into
devfrom
fix/sync-global-transform

Conversation

@mikhail-dcl

@mikhail-dcl mikhail-dcl commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Fixes #7315

With the wrong order there was one-frame gap that affected AvatarShapeHandlerSystem.LoadAvatarShape:

new CharacterInterpolationMovementComponent(
                    transformComponent.Transform.position,
                    transformComponent.Transform.position,
                    transformComponent.Transform.rotation),

@mikhail-dcl
mikhail-dcl requested review from a team as code owners May 20, 2026 10:33
@github-actions
github-actions Bot requested a review from anicalbano May 20, 2026 10:33
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

@mikhail-dcl mikhail-dcl changed the title Fix reconciliation of global entities position after the scene has concluded fix: reconciliation of global entities position after the scene has concluded May 20, 2026
@m3taphysics

Copy link
Copy Markdown
Contributor

PR #8828, run #26166189282

Builds: Windows change, Windows baseline, macOS change, macOS baseline

Framework 13 i7

Metric Change Baseline Delta Improvement
Samples 2700 2700
CPU average 33.3 ms 33.3 ms -0.0 ms 0.0%
CPU 1% worst 33.5 ms 33.6 ms -0.0 ms 0.1%
CPU 0.1% worst 35.0 ms 35.1 ms -0.2 ms 0.5%
GPU average 7.9 ms 7.7 ms 0.2 ms -2.2%
GPU 1% worst 18.8 ms 20.0 ms -1.2 ms 6.2% 🟢
GPU 0.1% worst 23.9 ms 27.9 ms -4.0 ms 14.3% 🟢

@DafGreco DafGreco left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • [✔️ ] Backpack and wearables in world
  • [✔️ ] Emotes in world and in backpack
  • [ ✔️] Teleport with map/coordinates/Jump In
  • [ ✔️] Chat and multiplayer
  • [ ✔️] Profile card
  • [ ✔️] Camera
  • [✔️ ] Skybox
  • [✔️ ] Settings

Evidence :

evidenceavatarshape.mp4
Image

@mikhail-dcl
mikhail-dcl enabled auto-merge (squash) May 20, 2026 14:36
@mikhail-dcl
mikhail-dcl merged commit 6b37b4a into dev May 20, 2026
21 of 26 checks passed
@mikhail-dcl
mikhail-dcl deleted the fix/sync-global-transform branch May 20, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only rendering AvatarShape with delay

3 participants