Skip to content

fix: reconciliation of global entities position after the scene has concluded #8828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikhail-dcl merged 1 commit into from
May 20, 2026
Merged

fix: reconciliation of global entities position after the scene has concluded #8828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Explorer/Assets/DCL/Infrastructure/ECS/SceneLifeCycle/Systems/GatherGltfAssetsSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using ECS.SceneLifeCycle.Reporting;
using ECS.Unity.GLTFContainer.Components;
using ECS.Unity.Transforms.Components;
using ECS.Unity.Transforms.Systems;
using SceneRunner.Scene;
using System;
using System.Collections.Generic;
Expand All @@ -18,6 +19,9 @@
namespace ECS.SceneLifeCycle.Systems
{
[UpdateInGroup(typeof(SyncedPreRenderingSystemGroup))]

// SyncGlobalTransformSystem must run after to reconcile the player entity position after Conclude() was called
[UpdateBefore(typeof(SyncGlobalTransformSystem))]
public partial class GatherGltfAssetsSystem : BaseUnityLoopSystem
{
private static readonly TimeSpan TIMEOUT = TimeSpan.FromSeconds(60);
Expand Down
Loading