Skip to content
This repository was archived by the owner on Jul 10, 2026. It is now read-only.

test: ci cache probe (identical to #132) #133

Closed
xorsal wants to merge 5 commits into from
Closed

test: ci cache probe (identical to #132) #133

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d05889d
test: flip assertion to make the test fail
xorsal May 25, 2026
fc07f23
chore: retrigger CI for canary validation
alice-aztec[bot] May 26, 2026
ca9d182
chore: trigger CI
xorsal May 26, 2026
9e40520
chore: trigger CI
xorsal May 26, 2026
1070279
chore: probe ci on fresh sha
xorsal May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ts/counter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@
from: alice,
})
).result,
).toBe(1n);
).toBe(999n);

Check failure on line 55 in src/ts/counter.test.ts

View workflow job for this annotation

GitHub Actions / checks / JS Tests

src/ts/counter.test.ts > Counter Contract > e2e 

AssertionError: expected 1n to be 999n // Object.is equality

- Expected
+ Received

- 999n
+ 1n

 ❯ src/ts/counter.test.ts:55:7

@qodo-code-review qodo-code-review Bot May 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Wrong increment expectation 🐞 Bug ≡ Correctness

src/ts/counter.test.ts now asserts the counter becomes 999n after a single increment(), but
the contract increments by exactly 1 from the default 0. This will fail CI and misrepresents the
Counter contract behavior.
Agent Prompt 
## Issue description
The TypeScript e2e test expects `999n` after a single `increment()`, but the Counter contract increments the stored counter by `+1`, so the correct expected value is `1n`.

## Issue Context
- Contract logic increments `current_value + 1`.
- Noir tests already assert the post-increment value is `1`.

## Fix Focus Areas
- src/ts/counter.test.ts[55-55]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@cubic-dev-ai cubic-dev-ai Bot May 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: The test expectation was changed to an incorrect counter value (999n), which breaks the correctness of this integration test.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At src/ts/counter.test.ts, line 55:

<comment>The test expectation was changed to an incorrect counter value (`999n`), which breaks the correctness of this integration test.</comment>

<file context>
@@ -52,6 +52,6 @@ describe("Counter Contract", () => {
         })
       ).result,
-    ).toBe(1n);
+    ).toBe(999n);
   });
 });
</file context>
Suggested change
).toBe(999n);
).toBe(1n);
Fix with Cubic

});
});
Loading